Bug 604599 - Don't omit notifications for downloads
Don't omit notifications for downloads
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-12-15 07:53 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2009-12-29 20:29 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't omit notifications for downloads (2.86 KB, patch)
2009-12-15 07:53 UTC, Diego Escalante Urrelo (not reading bugmail) 		none Details | Diff | Review
Don't omit notifications for downloads (2.51 KB, patch)
2009-12-29 11:06 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Diego Escalante Urrelo (not reading bugmail) 2009-12-15 07:53:11 UTC 
Current download notifications code depends on a GtkStatusIcon being embedded
in the tray, this is prone to fail in a bunch of situations and hence leave the
users wondering what happened with their downloads: did they finish or what?

This patch removes such dependency and also removes the timeout being used.

A case can be easily triggered while testing Bug #594192, you'll see that if
you take long enough to choose a destination while downloading, when you
finally pick one and the GtkFileChooserDialog is closed, you won't see any kind
of feedback about the completion of the download, despite it indeed was
completed.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2009-12-15 07:53:14 UTC 
Created attachment 149745 [details] [review]
Don't omit notifications for downloads

If a download is finished while the GtkStatusIcon for DownloadView is not
embedded the finished notification for such download is missed and user is left
wondering what happened with his/her download.
This makes notifications show whether there is or not a GtkStatusIcon to attach
to.

Bug #604599
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2009-12-29 11:06:08 UTC 
Created attachment 150530 [details] [review]
Don't omit notifications for downloads

If a download is finished while the GtkStatusIcon for DownloadView is not
embedded the finished notification for such download is missed and user is left
wondering what happened with his/her download.
This makes notifications show whether there is or not a GtkStatusIcon to attach
to.

Bug #604599
Comment 3 Gustavo Noronha (kov) 2009-12-29 20:25:21 UTC 
Review of attachment 150530 [details] [review]:

Yeah, I tried to touch that code when I was reimplementing download. Hairy.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2009-12-29 20:29:15 UTC 
Attachment 150530 [details] pushed as fab4ce4 - Don't omit notifications for downloads
Note You need to log in before you can comment on or make changes to this bug.