After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604495 - seahorse-plugins FTBFS on GNU/Hurd because of MAXPATHLEN usage
seahorse-plugins FTBFS on GNU/Hurd because of MAXPATHLEN usage
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: General
2.29.x
Other GNU Hurd
: Normal normal
: 2.24
Assigned To: seahorse-plugins-maint
seahorse-plugins-maint
Depends on:
Blocks:
 
 
Reported: 2009-12-13 23:25 UTC by Emilio Pozuelo Monfort
Modified: 2009-12-14 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use dynamic allocation instead of MAXPATHLEN size buffers (3.96 KB, patch)
2009-12-13 23:26 UTC, Emilio Pozuelo Monfort 		accepted-commit_now Details | Review

Description Emilio Pozuelo Monfort 2009-12-13 23:25:41 UTC 
Hi,

seahorse-plugins uses MAXPATHLEN unconditionally, which is undefined on GNU/Hurd as there's no maximum path length limit.

The attached patch makes use of dynamic allocation to fix this problem.
Comment 1 Emilio Pozuelo Monfort 2009-12-13 23:26:31 UTC 
Created attachment 149662 [details] [review]
Use dynamic allocation instead of MAXPATHLEN size buffers
Comment 2 Adam Schreiber 2009-12-14 01:56:28 UTC 
Review of attachment 149662 [details] [review]:

Looks good.  Let me know if you don't have commit access.
Comment 3 Emilio Pozuelo Monfort 2009-12-14 15:29:32 UTC 
Thanks, committed:
http://git.gnome.org/cgit/seahorse-plugins/commit/?id=d622b7002ae7bc56725205ba2d004a35217ef951