After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604333 - Remove the font API
Remove the font API
Status: RESOLVED FIXED
Product: gtkglext
Classification: Other
Component: gdk
master/HEAD
Other Linux
: Normal normal
: 2.0.0
Assigned To: Braden
Mukund Sivaraman
: 599338 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-12-11 04:19 UTC by Mukund Sivaraman
Modified: 2010-04-26 04:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove gdk_gl_font_use_pango_font_(for_display) (24.76 KB, patch)
2009-12-11 05:18 UTC, Braden
none Details | Review
Remove the gdk_gl_font_use_pango_font(_for_display) API functions (25.74 KB, patch)
2009-12-14 09:01 UTC, Braden
accepted-commit_now Details | Review
Remove the gdk_gl_font_use_pango_font(_for_display) API functions (33.82 KB, patch)
2010-01-13 08:55 UTC, Braden
needs-work Details | Review
Remove the gdk_gl_font_use_pango_font(_for_display) API functions (26.97 KB, patch)
2010-04-26 04:18 UTC, Braden
none Details | Review

Description Mukund Sivaraman 2009-12-11 04:19:03 UTC
The maintainers agree on the list that the font API as it exists currently in gtkglext should be removed. This is a bug to track that work.

This work should be done for the 2.0.0 release.
Comment 1 Braden 2009-12-11 05:18:30 UTC
Created attachment 149564 [details] [review]
Remove gdk_gl_font_use_pango_font_(for_display)
Comment 2 Braden 2009-12-14 09:01:25 UTC
Created attachment 149684 [details] [review]
Remove the gdk_gl_font_use_pango_font(_for_display) API functions

Refresh against current master.
Comment 3 Mukund Sivaraman 2009-12-23 09:24:01 UTC
Review of attachment 149684 [details] [review]:

By visual review, it looks good. If it builds (with the rest of examples),
please go ahead and commit. Am glad this API is going.

Let's also add a section in the gtk-doc API docs about removed API and what
alternatives users can use instead. I feel many would prefer to use the
Pango API directly like in the FT2 example, and it looks much better too.
Comment 4 Braden 2010-01-13 08:55:26 UTC
Created attachment 151320 [details] [review]
Remove the gdk_gl_font_use_pango_font(_for_display) API functions

This updates the patch for current master and culls the relevant bits from the documentation.

It's not quite ready to go as there's some noise in the generated doc files that we have checked in. The ones on master need to be refreshed.
Comment 5 Braden 2010-04-26 04:18:49 UTC
Created attachment 159567 [details] [review]
Remove the gdk_gl_font_use_pango_font(_for_display) API functions

Patch updated for current master.
Comment 6 Braden 2010-04-26 04:22:53 UTC
This patch hasn't substantially changed since Mukund's previous review; committed.
Comment 7 Braden 2010-04-26 04:24:29 UTC
*** Bug 599338 has been marked as a duplicate of this bug. ***