Bug 604294 – gnome-system-log assert failure: gnome-system-log:ERROR:logview-log.c:910:logview_log_get_uri: assertion failed: (LOGVIEW_IS_LOG (log))

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 604294 - gnome-system-log assert failure: gnome-system-log:ERROR:logview-log.c:910:logview_log_get_uri: assertion failed: (LOGVIEW_IS_LOG (log))


Summary:	gnome-system-log assert failure: gnome-system-log:ERROR:logview-log.c:910:log...


Status:	RESOLVED WONTFIX

Product:	gnome-system-log
Classification:	Core
Component:	general
Version:	git master
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	gnome-system-log-maint
QA Contact:	gnome-system-log-maint

URL:
Whiteboard:	gnome[unmaintained]

Depends on:
Blocks:

Reported:	2009-12-10 17:46 UTC by Pedro Villavicencio
Modified:	2020-09-26 09:41 UTC

See Also:
GNOME target:	---
GNOME version:	2.27/2.28

Description Pedro Villavicencio 2009-12-10 17:46:16 UTC

this report has been filed here:

https://bugs.launchpad.net/ubuntu/+source/gnome-utils/+bug/486380

"to reproduce crash:
close all files in gnome-system-log fast one by one"

".

+ Trace 219550

Thread 1 (process 4854)

#0 *__GI_raise
at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
#1 *__GI_abort
at abort.c line 92
#2 g_assertion_message
from /lib/libglib-2.0.so.0
#3 g_assertion_message_expr
from /lib/libglib-2.0.so.0
#4 logview_log_get_uri
at logview-log.c line 910
#5 logview_manager_close_active_log
at logview-manager.c line 388
#6 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#7 ??
from /usr/lib/libgobject-2.0.so.0
#8 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#9 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#10 _gtk_action_emit_activate
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkaction.c line 727
#11 closure_accel_activate
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkaction.c line 1647
#12 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#13 ??
from /usr/lib/libgobject-2.0.so.0
#14 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#15 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#16 IA__gtk_accel_group_activate
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkaccelgroup.c line 860
#17 IA__gtk_accel_groups_activate
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkaccelgroup.c line 897
#18 IA__gtk_window_activate_key
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkwindow.c line 8269
#19 gtk_window_key_press_event
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkwindow.c line 5170
#20 _gtk_marshal_BOOLEAN__BOXED
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmarshalers.c line 84
#21 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#22 ??
from /usr/lib/libgobject-2.0.so.0
#23 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#24 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#25 gtk_widget_event_internal
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkwidget.c line 4767
#26 IA__gtk_propagate_event
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmain.c line 2391
#27 IA__gtk_main_do_event
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmain.c line 1622
#28 ??
from /usr/lib/libgdk-x11-2.0.so.0
#29 g_main_context_dispatch
from /lib/libglib-2.0.so.0
#30 ??
from /lib/libglib-2.0.so.0
#31 g_main_loop_run
from /lib/libglib-2.0.so.0
#32 IA__gtk_main
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmain.c line 1218
#33 main
at logview-main.c line 118

Comment 1 Artem Kuskis 2013-10-02 05:27:45 UTC

Bug: When you press Ctrl+W and there is no log file selected in the left widget...

Must be fixed after patch 11 Apr 2013

Patch info : https://git.gnome.org/browse/gnome-system-log/commit/src/logview-manager.c?id=ad9153b8bcd8a2556d7a1f5fcca890680c4677de

Patch file:

From ad9153b8bcd8a2556d7a1f5fcca890680c4677de Mon Sep 17 00:00:00 2001
From: Cosimo Cecchi <cosimoc@gnome.org>
Date: Thu, 11 Apr 2013 21:25:20 +0000
Subject: manager: add some safety NULL-checks

https://bugzilla.gnome.org/show_bug.cgi?id=697790
---
(limited to 'src/logview-manager.c')

diff --git a/src/logview-manager.c b/src/logview-manager.c
index 29dcba9..b948bfa 100644
--- a/src/logview-manager.c
+++ b/src/logview-manager.c
@@ -398,6 +398,10 @@ logview_manager_close_active_log (LogviewManager *manager)
   g_assert (LOGVIEW_IS_MANAGER (manager));

   active_log = manager->priv->active_log;
+ if (active_log == NULL) {
+ return;
+ }
+
   log_uri = logview_log_get_uri (active_log);
   file = logview_log_get_gfile (active_log);

[...]
--
cgit v0.9.2


Sorry, can't check master branch, problems with JHBuild and Centos6.
But in older versions, checking pointer on NULL - fixed this bug.

Comment 2 André Klapper 2020-09-26 09:41:08 UTC

gnome-system-log is not under active development anymore and had its last code changes more than four years ago. Its codebase has been archived at https://gitlab.gnome.org/Archive/gnome-system-log/

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.