After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604270 - Tag icons visible even after turned off in the UI
Tag icons visible even after turned off in the UI
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.6.1
Other Linux
: Normal normal
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-10 12:56 UTC by Janne
Modified: 2010-06-30 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Hide the picture tags in tag_view depending upon the tag icon preference (2.00 KB, patch)
2010-01-12 16:28 UTC, Iain Churcher
committed Details | Review

Description Janne 2009-12-10 12:56:52 UTC
You can turn tag icons off by selecting in "Show"-> "Tag icons"->"Hidden" (or similar in the English UI), and unchecking the checkbox in ""Show"-> "miniature picture elements" -> "tags". This will remove them in most places.

However, they still show up below the image in the single-image view, to the left of the comment field. This causes the UI to behave strangely when you have a lot of tags for one image (see bug #574257), and is of course against the wishes of the user who is trying to turn off the icons.

So, the icons should probably be turned off when the "miniature picture elements"->"tags" is unchecked, just like they are in the image collection view.
Comment 1 Iain Churcher 2010-01-12 16:28:39 UTC
Created attachment 151262 [details] [review]
Hide the picture tags in tag_view depending upon the tag icon preference

Hi,

I have had a go at patching this bug and believe I have successfully tied the showing/hiding of the tags next to the "Comment:" field to the View->TagIcons menu. Selecting 'Hidden' will remove the tag icons and selecting any other size will bring them back.

Please test and review as required.

Regards

Iain Churcher
Comment 2 Janne 2010-01-18 12:17:01 UTC
Whoho! The single most annoying bug in my whole desktop may actually be fixed! 

How would I go about testing this?
Comment 3 Ruben Vermeersch 2010-06-30 14:25:53 UTC
Attachment 151262 [details] pushed as fa7657d - Hide the picture tags in tag_view depending upon the tag icon preference



Works indeed, merged!