After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604258 - hard margins need to take into account page scale
hard margins need to take into account page scale
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Printing
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599468
 
 
Reported: 2009-12-10 11:30 UTC by Adrian Johnson
Modified: 2018-02-10 03:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
take page scale into account when setting hard margins on the print context (1.97 KB, patch)
2009-12-10 11:33 UTC, Adrian Johnson
none Details | Review
take page scale into account when setting hard margins on the print context (1.99 KB, patch)
2010-12-29 03:01 UTC, Adrian Johnson
none Details | Review
take page scale into account when setting hard margins on the print context (1.98 KB, patch)
2012-03-12 13:07 UTC, Adrian Johnson
none Details | Review

Description Adrian Johnson 2009-12-10 11:30:54 UTC
Bug 468989 added the ability to obtain the printer hard margins from the print context. This works fine when the page scale is 100%. At other scales the hard margins on the context should be adjusted so that after scaling they match the physical hard margins.

For example, with scale = 100%, a print context may return the top,left,right, and bottom hard margins all equal to 0.5". If the scale is set to 50%, the point (0.5", 0.5") will be printed at (0.25", 0.25") which is outside of the printable area. In this case the top and left hard margins on the print context should scaled up to 0.5".

The point (paper_width, paper_height) at 100% scale would be outside the printable area but at 50% scale would be inside the printable area. In this case the bottom and right hard margins on the print context should be set to 0.
Comment 1 Adrian Johnson 2009-12-10 11:33:21 UTC
Created attachment 149512 [details] [review]
take page scale into account when setting hard margins on the print context

Patch to fix this.
Comment 2 Adrian Johnson 2010-12-29 03:01:15 UTC
Created attachment 177171 [details] [review]
take page scale into account when setting hard margins on the print context

Rebasing to git master.
Comment 3 Adrian Johnson 2012-03-12 13:07:15 UTC
Created attachment 209479 [details] [review]
take page scale into account when setting hard margins on the print context

Another 12 months has passed. Rebasing to master.
Comment 4 Matthias Clasen 2018-02-10 03:36:18 UTC
We're moving to gitlab! As part of this move, we are closing bugs that haven't seen activity in more than 5 years. If this issue is still imporant to you and
still relevant with GTK+ 3.22 or master, please consider creating a gitlab issue
for it.