GNOME Bugzilla – Bug 604186
Remove gnome-vfs use in plugins
Last modified: 2009-12-11 01:53:52 UTC
Some of the Python plugins still rely on gnome-vfs. The use should be completely removed, and the latest pygobject bindings required instead.
- Remove gnome-vfs in the rb module - Remove the gnome-vfs fallback in the artdisplay plugin - Remove the single line of gnomevfs usage in upnp plugin
Sounds like a good plan to me.
Created attachment 149530 [details] [review] Remove gnome-vfs support in artdisplay plugin
Created attachment 149531 [details] [review] Require a new enough pygobject for GIO functions
Created attachment 149532 [details] [review] Remove gnome-vfs support in rb python bindings
Comment on attachment 149530 [details] [review] Remove gnome-vfs support in artdisplay plugin might as well rename LocalCoverArtSearchGIO.py to LocalCoverArtSearch.py, since I don't think we'll be adding any other implementations
Review of attachment 149532 [details] [review]: ::: plugins/rb/Loader.py @@ +190,3 @@ # now figure out which set of implementations to use +import gio should import gio at the top of the file now @@ +194,3 @@ +Loader = GioLoader +ChunkLoader = GioChunkLoader +UpdateCheck = GioUpdateCheck might as well just rename the classes, since we're probably not going to add other implementations
Review of attachment 149531 [details] [review]: OK
Attachment 149530 [details] pushed as 3dce1f2 - Remove gnome-vfs support in artdisplay plugin Attachment 149531 [details] pushed as 5578742 - Require a new enough pygobject for GIO functions Attachment 149532 [details] pushed as 53f32ed - Remove gnome-vfs support in rb python bindings