After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604186 - Remove gnome-vfs use in plugins
Remove gnome-vfs use in plugins
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 604188
Blocks: 588322
 
 
Reported: 2009-12-09 15:49 UTC by Bastien Nocera
Modified: 2009-12-11 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove gnome-vfs support in artdisplay plugin (8.99 KB, patch)
2009-12-10 16:18 UTC, Bastien Nocera
committed Details | Review
Require a new enough pygobject for GIO functions (942 bytes, patch)
2009-12-10 16:18 UTC, Bastien Nocera
committed Details | Review
Remove gnome-vfs support in rb python bindings (4.74 KB, patch)
2009-12-10 16:18 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2009-12-09 15:49:47 UTC
Some of the Python plugins still rely on gnome-vfs.

The use should be completely removed, and the latest pygobject bindings required instead.
Comment 1 Bastien Nocera 2009-12-09 15:53:21 UTC
- Remove gnome-vfs in the rb module
- Remove the gnome-vfs fallback in the artdisplay plugin
- Remove the single line of gnomevfs usage in upnp plugin
Comment 2 Jonathan Matthew 2009-12-09 21:12:07 UTC
Sounds like a good plan to me.
Comment 3 Bastien Nocera 2009-12-10 16:18:44 UTC
Created attachment 149530 [details] [review]
Remove gnome-vfs support in artdisplay plugin
Comment 4 Bastien Nocera 2009-12-10 16:18:50 UTC
Created attachment 149531 [details] [review]
Require a new enough pygobject for GIO functions
Comment 5 Bastien Nocera 2009-12-10 16:18:56 UTC
Created attachment 149532 [details] [review]
Remove gnome-vfs support in rb python bindings
Comment 6 Jonathan Matthew 2009-12-10 23:53:57 UTC
Comment on attachment 149530 [details] [review]
Remove gnome-vfs support in artdisplay plugin

might as well rename LocalCoverArtSearchGIO.py to LocalCoverArtSearch.py, since I don't think we'll be adding any other implementations
Comment 7 Jonathan Matthew 2009-12-11 00:05:24 UTC
Review of attachment 149532 [details] [review]:

::: plugins/rb/Loader.py
@@ +190,3 @@
 # now figure out which set of implementations to use
 
+import gio

should import gio at the top of the file now

@@ +194,3 @@
+Loader = GioLoader
+ChunkLoader = GioChunkLoader
+UpdateCheck = GioUpdateCheck

might as well just rename the classes, since we're probably not going to add other implementations
Comment 8 Jonathan Matthew 2009-12-11 00:21:47 UTC
Review of attachment 149531 [details] [review]:

OK
Comment 9 Bastien Nocera 2009-12-11 01:53:38 UTC
Attachment 149530 [details] pushed as 3dce1f2 - Remove gnome-vfs support in artdisplay plugin
Attachment 149531 [details] pushed as 5578742 - Require a new enough pygobject for GIO functions
Attachment 149532 [details] pushed as 53f32ed - Remove gnome-vfs support in rb python bindings