After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604100 - rtpmux: add seqnum-base to the buffer-caps
rtpmux: add seqnum-base to the buffer-caps
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-08 17:26 UTC by Håvard Graff (hgr)
Modified: 2009-12-09 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.21 KB, patch)
2009-12-08 17:26 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2009-12-08 17:26:04 UTC 
Created attachment 149359 [details] [review]
patch

Needed to to proper caps-nego with payloaders.
Comment 1 Wim Taymans 2009-12-09 14:23:59 UTC 
This patch does not make sense.

 * doing make_writable on each passing buffer without making the buffer metadata
   writable is very bad.
 * right after setting the buffer caps, they get overwritten again by
   padpriv->outcaps, which contains the seqnum-base because it was added in
   setcaps().

what's the plan here?
Comment 2 Håvard Graff (hgr) 2009-12-09 14:50:00 UTC 
No plan. The patch was for an older version, and I had not registered that seqnum-base now is part of the caps. Please disregard :)