GNOME Bugzilla – Bug 604067
[PLUGIN-MOVE] Move assrender to gst-plugins-good
Last modified: 2018-11-03 14:40:24 UTC
See summary. The plugin is mature now, and together with latest git of gst-plugins-base it will be automatically used for ASS/SSA subtitles and provides much better visual results because it supports all ASS/SSA features. There's no test for it and I don't know how one should look, documentation will come in the next days but that won't contain much interesting information (because the element is meant to be automatically used).
commit c3e42004d1bd086a78504562de4ddf42ed197010 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Tue Dec 8 14:46:35 2009 +0100 assrender: Add docs and integrate into the docs build system
Maybe some kind of test with playbin2 + an appsrc:// URI and an ASS/SSA file as suburi - then just push black video buffers into appsrc and see what happens overlay-wise? Anything that runs the common code paths through check+valgrind should be fine IMHO.
Yes a test like that exists already in tests/check/elements/shapewipe :) And a test to look at in tests/examples/shapewipe (you need a mask file for that).
> Yes a test like that exists already in tests/check/elements/shapewipe :) And a > test to look at in tests/examples/shapewipe (you need a mask file for that). That's great, but isn't this bug about the assrender plugin move? :)
Oops, yes :) Well, then nothing exists yet
So, what's happening with this? Could you run down the moving-plugins check list? There's only a few days left..
Nothing for this release, a test is missing and a second review.
...and now only a second review is missing. Who wants to do it? ;) commit 88bd4a8ada893b16d9c3e6f609fa84195ab036e3 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Tue Feb 16 21:41:38 2010 +0100 assrender: Add simple unit test This renders a test string on top of a red video stream and checks if the text is only rendered at the correct timestamps.
Setting target milestone to 0.10.22 because everything is ready now I think and it should be moved.
> Setting target milestone to 0.10.22 because everything is ready now I think and > it should be moved. Not in this cycle, next is core/base/good, and then good/ugly/bad again in May, see http://gstreamer.freedesktop.org/wiki/ReleasePlanning2010, so unsetting blocker again for now :) I think there are also still a few open bugs wrt matroska and ass subtitles (random jerks during playback, weird behaviour after seeking)?
When running the tests I get quite a lot of stdout printfs. Can we handle that better? If that comes from libass, is there a log handler that we can use to redirect this to the gst-debug log? Running suite(s): assrender [ass] **MSGL_V**: FreeType library version: 2.3.9 [ass] **MSGL_V**: FreeType headers version: 2.3.9 [ass] **MSGL_INFO**: [ass] Init [ass] **MSGL_V**: event: [Script Info] ; This is a Sub Station Alpha v4 script. ; For Sub Station Alpha info and downloads, ; go to http://www.eswat.demon.co.uk/ Title: Some Test Script Updated By: version 2.8.01 ScriptType: v4.00 Collisions: Normal PlayResY: 200 PlayDepth: 0 Timer: 100,0000 [V4 Styles] Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, TertiaryColour, BackColour, Bold, Italic, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, AlphaLevel, Encoding Style: DefaultVCD, Arial,28,11861244,11861244,11861244,-2147483640,-1,0,1,1,2,2,30,30,30,0,0 [Events] Format: Marked, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text [ass] **MSGL_V**: [0x9e6b590] Style: DefaultVCD, Arial,28,11861244,11861244,11861244,-2147483640,-1,0,1,1,2,2,30,30,30,0,0 [ass] **MSGL_V**: event at 40, +60: 1,,DefaultVCD, NTP,0000,0000,0000,,Some Test Blabla [ass] **MSGL_WARN**: [ass] PlayResX undefined, setting 267. [ass] **MSGL_V**: [ass] Font info: family 'Arial', style 'Negreta', fullname 'Arial Negreta', slant 0, weight 200 [ass] **MSGL_V**: fontconfig_select: (Arial, 200, 0) -> /usr/share/fonts/truetype/msttcorefonts/Arial_Bold.ttf, 0 [ass] **MSGL_V**: cache statistics: total accesses: 2 hits: 1 misses: 1 object count: 1 [ass] **MSGL_V**: cache statistics: total accesses: 32 hits: 20 misses: 12 object count: 12 [ass] **MSGL_V**: cache statistics: total accesses: 16 hits: 8 misses: 8 object count: 8 [ass] **MSGL_V**: cache statistics: total accesses: 32 hits: 20 misses: 12 object count: 12 [ass] **MSGL_V**: FreeType library version: 2.3.9 [ass] **MSGL_V**: FreeType headers version: 2.3.9 [ass] **MSGL_INFO**: [ass] Init [ass] **MSGL_V**: event: [Script Info] ; This is a Sub Station Alpha v4 script. ; For Sub Station Alpha info and downloads, ; go to http://www.eswat.demon.co.uk/ Title: Some Test Script Updated By: version 2.8.01 ScriptType: v4.00 Collisions: Normal PlayResY: 200 PlayDepth: 0 Timer: 100,0000
(In reply to comment #11) > When running the tests I get quite a lot of stdout printfs. Can we handle that > better? If that comes from libass, is there a log handler that we can use to > redirect this to the gst-debug log? Look at this block somewhere at the top of gstassrender.c: #if defined(LIBASS_VERSION) && LIBASS_VERSION >= 0x00907000 static void _libass_message_cb [...] You need libass 0.9.7 or newer for this.
Let's put this off, there are still a few bugs that should be sorted out before the move IMHO.
It should now be ported to the new video overlay composition API
It is ported to the video overlay composition API since bug #692012
Automated removal of (bad) usage of the "NONE" target milestone.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/18.