GNOME Bugzilla – Bug 603829
Use single GTK+ includes
Last modified: 2009-12-07 05:59:00 UTC
GTK+ and other libraries will require that only their top-level header file is included. See http://live.gnome.org/GnomeGoals/CleanupGTKIncludes for more info
Created attachment 149132 [details] [review] Use single GTK+ includes
(In reply to comment #1) > Created an attachment (id=149132) [details] [review] > Use single GTK+ includes The includes patch seems OK, but is adding atk as a dependency required? Doesn't it get pulled automatically as a gtk+ dependency? I'll look into this and commit the patch.
A modified version of the patch in comment #1 was committed in the master branch in 00f05b44359c3894f7f6a9b6c836489579cf749b.
Resolving as FIXED, milestone unspecified (as we haven't setup milestones yet). Javier: Please verify that master branch builds properly and verify this bug.
Reopened because this bug is still not fixed. Here a new patch to compile gtkglext and use only single includes: make CFLAGS+="-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES"
Created attachment 149176 [details] [review] Use single GTK+ includes. second patch
Comment on attachment 149132 [details] [review] Use single GTK+ includes committed a slightly modified patch commit 00f05b44359c3894f7f6a9b6c836489579cf749b
Review of attachment 149176 [details] [review]: Committed in master branch in 10e05cd56615ab5296cf44bc6e4bfb677b7ac93d.
Resolving as FIXED, milestone unspecified (as we haven't setup milestones yet). Javier: Please verify that master branch builds properly and verify this bug. I have also compiled gtkglext master with the CFLAGS from comment #5 and verified that it builds.
Hello Mukund, verified that master builds correct after latest commit. Thank you for apply the patch.