After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603780 - bad assembly in gatomic.c for armv7 with thumb2
bad assembly in gatomic.c for armv7 with thumb2
Status: RESOLVED DUPLICATE of bug 531902
Product: glib
Classification: Platform
Component: general
2.23.x
Other Linux
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-12-04 11:37 UTC by Alexander Sack
Modified: 2010-04-12 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use gcc intrinsics instead of inline asm if supported (2.32 KB, application/octet-stream)
2009-12-04 11:37 UTC, Alexander Sack 		  Details
improved patch (2.87 KB, patch)
2009-12-04 11:44 UTC, Alexander Sack 		none Details | Review

Description Alexander Sack 2009-12-04 11:37:57 UTC 
Created attachment 149080 [details]
use gcc intrinsics instead of inline asm if supported

Launchpad bug: https://launchpad.net/bugs/491342

latest glib upload failed to build in lucid:

12:52 < asac> https://edge.launchpad.net/ubuntu/+source/glib2.0/2.23.0-1ubuntu1/+build/1374402
12:53 < asac> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/build/buildd/glib2.0-2.23.0/glib -I.. -I/build/buildd/glib2.0-2.23.0 -DG_LOG_DOMAIN=\"GLib\" -DG_ENABLE_DEBUG
              -DG_DISABLE_DEPRECATED -DGLIB_COMPILATION -DPCRE_STATIC -DG_DISABLE_SINGLE_INCLUDES -pthread -g -O2 -Wall -g -O2 -MT gatomic.lo -MD -MP -MF
              .deps/gatomic.Tpo -c /build/buildd/glib2.0-2.23.0/glib/gatomic.c -fPIC -DPIC -o .libs/gatomic.o
12:53 < asac> /tmp/cc7twNnB.s: Assembler messages:
12:53 < asac> /tmp/cc7twNnB.s:161: Error: selected processor does not support `swp r3,r5,[r4]'
12:53 < asac> /tmp/cc7twNnB.s:179: Error: selected processor does not support `swp r3,r5,[r4]'

attaching patch by Dave Martin <Dave.Martin@arm.com> submitted here:

  https://bugs.edge.launchpad.net/ubuntu/+source/glib2.0/+bug/491342/comments/5
Comment 1 Alexander Sack 2009-12-04 11:44:26 UTC 
Created attachment 149081 [details] [review]
improved patch

better patch combining the previous one and the improvement patch posted here: https://bugs.edge.launchpad.net/glib/+bug/491342/comments/8
Comment 2 Adrian Bunk 2009-12-20 09:32:58 UTC 
Can someone with sufficient permissions close this bug as duplicate of #498810 ?

It doesn't make sense to discuss different solutions for the same issue in different bugs.
Comment 3 Hiroyuki Ikezoe 2010-01-05 10:41:41 UTC 
After I took a look into the patch, I'd rather make this bug as a duplicate of bug 498810.
Comment 4 Hiroyuki Ikezoe 2010-01-05 10:42:13 UTC 
Oops! I meant bug 531902.
Comment 5 Hiroyuki Ikezoe 2010-01-07 11:25:53 UTC 
Now glib can be compiled with -mthumb and march=armv7-a options if GCC is newer than 4.4.1. I confirmed it with gcc (Ubuntu 4.4.1-4ubuntu8) 4.4.1 on Ubuntu karmic on ARM.

Alexander, I will close this bug as a duplicate of bug 531902, if you Ubuntu guys are OK.
Comment 6 Loïc Minier 2010-02-09 14:30:52 UTC 

*** This bug has been marked as a duplicate of bug 531902 ***
Comment 7 Alexander Sack 2010-04-12 10:58:30 UTC 
we looked at recent update two weeks ago and it seems not all ops are now using intrisincs for arm ... seems the patch somehow was for ia64?