After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603756 - bug with runtime directory
bug with runtime directory
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.29.x
Other Solaris
: Normal normal
: ---
Assigned To: Brian Cameron
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-04 02:18 UTC by Brian Cameron
Modified: 2010-07-02 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch fixing issue. (1.44 KB, patch)
2009-12-04 02:18 UTC, Brian Cameron
accepted-commit_now Details | Review

Description Brian Cameron 2009-12-04 02:18:55 UTC
Created attachment 149065 [details] [review]
patch fixing issue.

Ever since the code to add the /var/run/gdm/greeter code landed in master, I have been seeing this in my syslog when I turn on GDM debug:

GdmWelcomeSession: Setting up run time dir (|^D^Hj\331^F^H^X\354^H\240l^H(|^D^HR\331^F^H^X\347 ^H^
GdmWelcomeSession: Changing (uid:gid) for child process to (50:50)
GdmWelcomeSession: Started D-Bus daemon on pid 1435

Looking more closely at the log, it seems that the corrupted directory value only gets printed before launching the D-Bus daemon.  The message is always the following when running the actual session:

GdmWelcomeSession: Setting up run time dir /var/run/gdm/greeter

In addition to the corrupted log message, I also noticed the more serious problem that GDM was creating empty directories in my top-level (/) directory with similarly corrupted names.

The problem is that data.runtime_dir is not getting set to anything when spawn_command_line_sync_as_user is called.

The attached patch fixes the problem.
Comment 1 Ray Strode [halfline] 2009-12-04 20:57:09 UTC
Comment on attachment 149065 [details] [review]
patch fixing issue.

looks good, thanks
Comment 2 Brian Cameron 2009-12-05 00:42:55 UTC
Committed to master.