After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603745 - [dc1394src] add "iso-speed" property
[dc1394src] add "iso-speed" property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-03 23:26 UTC by Tristan Matthews
Modified: 2010-03-09 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to add iso-speed property to dc1394src (3.46 KB, patch)
2009-12-03 23:26 UTC, Tristan Matthews
none Details | Review
adds property to dc1394src to set iso speed (4.30 KB, patch)
2009-12-08 20:47 UTC, Tristan Matthews
none Details | Review
add iso-speed property (4.55 KB, patch)
2009-12-08 22:23 UTC, Tristan Matthews
none Details | Review
adds iso-speed property (3.40 KB, patch)
2009-12-08 23:45 UTC, Tristan Matthews
none Details | Review
adds iso-speed property (7.70 KB, patch)
2009-12-08 23:48 UTC, Tristan Matthews
committed Details | Review

Description Tristan Matthews 2009-12-03 23:26:58 UTC
Created attachment 149055 [details] [review]
patch to add iso-speed property to dc1394src

It would be useful to have a property for setting the iso speed for dc1394src. Currently, it is always set to DC1394_ISO_SPEED_400. Attached is a patch that adds this property.
Comment 1 Tristan Matthews 2009-12-08 20:47:38 UTC
Created attachment 149368 [details] [review]
adds property to dc1394src to set iso speed

also sets b-mode if necessary (i.e. bandwidth is greater than 400).
Comment 2 Tristan Matthews 2009-12-08 22:23:10 UTC
Created attachment 149376 [details] [review]
add iso-speed property

adds iso-speed property, lists valid iso-speeds in help, validates iso-speed before setting it and sets bmode if necessary.
Comment 3 Tristan Matthews 2009-12-08 23:45:02 UTC
Created attachment 149381 [details] [review]
adds iso-speed property

created with 
git format-patch --stdout -3 > iso-speed.diff
Comment 4 Tristan Matthews 2009-12-08 23:48:50 UTC
Created attachment 149382 [details] [review]
adds iso-speed property
Comment 5 Tim-Philipp Müller 2010-03-09 23:47:08 UTC
commit 846c2db92676324e284f50886e746ff44cc114e3
Author: Tristan Matthews <tristan@sat.qc.ca>
Date:   Tue Dec 8 16:36:16 2009 -0500

    dc1394: list valid iso-speeds in help and validate speeds in set_property.

commit f8c1709b5fe382b32fdd8a99a5940d58af3f9af9
Author: Tristan Matthews <tristan@sat.qc.ca>
Date:   Tue Dec 8 16:05:14 2009 -0500

    dc1394: check iso-speed values in set_property, ignore if invalid

commit 0cb067987d0bc109e7f256cd73bfd5eef4436270
Author: Tristan Matthews <tristan@sat.qc.ca>
Date:   Tue Dec 8 15:37:03 2009 -0500

    dc1394: add iso-speed property
    
    Add iso-speed property which allows for higher bandwidth dc video.
    Automatically set to b-mode as needed.
    
    Fixes #603745.