After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603735 - Allow null/undefined to be passed in to callbacks
Allow null/undefined to be passed in to callbacks
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2009-12-03 21:35 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2009-12-04 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow null/undefined to be passed in to callbacks (1.55 KB, patch)
2009-12-03 21:35 UTC, Johan (not receiving bugmail) Dahlin 		none Details | Review
Allow null/undefined to be passed in to callbacks (1.63 KB, patch)
2009-12-03 21:48 UTC, Johan (not receiving bugmail) Dahlin 		accepted-commit_now Details | Review
Allow null/undefined to be passed in to callbacks (1.63 KB, patch)
2009-12-04 11:30 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2009-12-03 21:35:05 UTC 
Some functions do not require a callback to be passed in,
instead NULL is accepted, the same should be supported in gjs
by allowing null/undefined.
Comment 1 Johan (not receiving bugmail) Dahlin 2009-12-03 21:35:08 UTC 
Created attachment 149042 [details] [review]
Allow null/undefined to be passed in to callbacks
Comment 2 Johan (not receiving bugmail) Dahlin 2009-12-03 21:48:18 UTC 
Created attachment 149045 [details] [review]
Allow null/undefined to be passed in to callbacks

Some functions do not require a callback to be passed in,
instead NULL is accepted, the same should be supported in gjs
by allowing null/undefined.
Comment 3 Lucas Rocha 2009-12-04 11:28:15 UTC 
Review of attachment 149045 [details] [review]:

Looks good.
Comment 4 Johan (not receiving bugmail) Dahlin 2009-12-04 11:30:38 UTC 
The following fix has been pushed:
e2fe272 Allow null/undefined to be passed in to callbacks
Comment 5 Johan (not receiving bugmail) Dahlin 2009-12-04 11:30:44 UTC 
Created attachment 149079 [details] [review]
Allow null/undefined to be passed in to callbacks

Some functions do not require a callback to be passed in,
instead NULL is accepted, the same should be supported in gjs
by allowing null/undefined.