Created attachment 149023 [details] [review]
Use static wrappers for cairo structs (proof of concept)

This looks awful. What's the status of cairo-glib? Isn't it easier to push it forward?

Review of attachment 149023 [details] [review]:

Looks quite good for now, but I don't think we want a hard dependency on cairo.
Ideally it should be a runtime check instead of compile time. Is that doable?

(In reply to comment #3)
> Review of attachment 149023 [details] [review]:
> 
> Looks quite good for now, but I don't think we want a hard dependency on cairo.
> Ideally it should be a runtime check instead of compile time. Is that doable?

Cannot think of a way of doing this in runtime, any ideas?

What gjs is doing in https://bugzilla.gnome.org/show_bug.cgi?id=610357 may be a better alternative.

Created attachment 158844 [details] [review]
Add support for foreign structs

Review of attachment 158844 [details] [review]:

One minor comment.  In general this looks roughly right.

::: gi/pygi-argument.c
@@ +947,3 @@
+
+                        gint retval;
+                    } else if ((type == G_TYPE_NONE) && (g_struct_info_is_foreign (info))) {

This will overwrite the earlier exception that pygi_struct_foreign_convert_to_g_argument set, but that's probably OK.

Review of attachment 158844 [details] [review]:

One minor comment.  In general this looks roughly right.

::: gi/pygi-argument.c
@@ +947,3 @@
+
+                        gint retval;
+                    } else if ((type == G_TYPE_NONE) && (g_struct_info_is_foreign (info))) {

This will overwrite the earlier exception that pygi_struct_foreign_convert_to_g_argument set, but that's probably OK.

The following fix has been pushed:
a34cb9f Add support for foreign structs

Created attachment 158953 [details] [review]
Add support for foreign structs