GNOME Bugzilla – Bug 603696
soup-connection.h should be installed in include directory
Last modified: 2009-12-03 14:40:03 UTC
With bug 598163, a connection-created signal was added to SoupSession (note that it wasn't added to the soup-session.h, though; I'm not sure if it's to preserve the ABI or if it's an accident). If you connect to this signal, you'll get a SoupConnection object, which therefore should make SoupConnection public API. Note that the current situation breaks the gir-repository build: /gnome/usr/bin/g-ir-compiler --includedir=. --includedir=. Soup-2.4.gir -o Soup-2.4.typelib ** WARNING **: Entry 'SoupConnection' not found aborting... make: *** [Soup-2.4.typelib] Abandon
Created attachment 149007 [details] [review] Patch
Comment on attachment 149007 [details] [review] Patch SoupConnection is private (and eventually being replaced by something else as part of bug 591739). The goal of the 598163 patches was that soup-fly could treat the connection just as a GObject, using its properties and signals but not needing to know anything at compile time. I forgot that this would mess up introspection... But we definitely don't want to make SoupConnection public. So the right fix is to make the SoupSession:connection-created parameter be G_TYPE_OBJECT instead of SOUP_TYPE_CONNECTION. Feel free to do that and commit the change.
Yeah, I was wondering if it was right to do it this way. I pushed the fix you suggested, thanks!