After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603632 - metacity assert failure: metacity:ERROR:core/boxes.c:1161:meta_rectangle_edge_aligns: code should not be reached
metacity assert failure: metacity:ERROR:core/boxes.c:1161:meta_rectangle_edge...
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.34.x
Other Linux
: Normal critical
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
: 618537 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-12-02 18:37 UTC by Pedro Villavicencio
Modified: 2017-07-21 13:15 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
Fix crash when struts change during grab operation (6.33 KB, patch)
2010-02-09 22:27 UTC, Owen Taylor
none Details | Review

Description Pedro Villavicencio 2009-12-02 18:37:49 UTC
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/metacity/+bug/437139

".

Comment 1 Owen Taylor 2009-12-17 19:52:05 UTC
Fedora bug with a couple of duplicates: https://bugzilla.redhat.com/show_bug.cgi?id=540129 

I looked at this briefly and couldn't see anything obvious - reproduction instructions would be incredibly useful.
Comment 2 Florian Scandella 2009-12-18 13:12:08 UTC
just happened to me with mutter.

mutter:ERROR:core/boxes.c:1161:meta_rectangle_edge_aligns: code should not be reached

was moving a newly created window (tvtime), but i cannot reproduce it.
Comment 3 Florian Scandella 2009-12-18 13:13:45 UTC
sorry, forgot to add the last messages in the log:


Window manager warning: Buggy client sent a _NET_ACTIVE_WINDOW message with a timestamp of 0 for 0x2a00001 (tvtime)
Window manager warning: meta_window_activate called by a pager with a 0 timestamp; the pager needs to be fixed.
**
mutter:ERROR:core/boxes.c:1161:meta_rectangle_edge_aligns: code should not be reached
Shell killed with signal 6
Comment 4 Owen Taylor 2010-02-09 22:27:51 UTC
Created attachment 153369 [details] [review]
Fix crash when struts change during grab operation

Since meta_workspace_invalidate_work_area() frees the edges
workspace->screen_edges and workspace->monitor_edges, we must clean up
our cached edge resistance data when the invalidate_work_area() is
called on the active workspace, or when the workspace changes.

Make the computation of the edge resistance data lazy so that it
will be recomputed the next time we try to access it.
meta_display_compute_resistance_and_snapping_edges() is made
private to edge-resistance.c

Invaliding the data when active workspace changes also will improve
correctness for edge resistance when the current workspace changes
during a grab operation. (Even with this fix we still don't try to
handle window positions changing during a grab operation; that can't
cause a crash since, unlike screen and monitor edges, the window edges
are freshly allocated, it will just cause slight oddness in that
corner case.)

Root cause tracked down due to much effort by Jon Nettleton.
https://bugzilla.gnome.org/show_bug.cgi?id=608800 (Mutter)
https://bugzilla.gnome.org/show_bug.cgi?id=603632 (Metacity)
Comment 5 Owen Taylor 2010-02-09 22:29:54 UTC
Though I haven't tested it, the Metacity reproducer for this should be:

 - In a terminal - type 'sleep 10 && pkill gnome-panel'
 - Start dragging a window

You might have to this a few times, but eventually the strut change as gnome-panel restarts will trigger this crash.
Comment 6 Bill Nottingham 2010-05-13 13:33:32 UTC
*** Bug 618537 has been marked as a duplicate of this bug. ***
Comment 7 Pedro Villavicencio 2011-12-05 11:51:37 UTC
Last dupe we got on https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/889737 is with 2.34 , changing the version number.
Comment 8 Michael Terry 2012-02-29 19:17:07 UTC
I just tried the patch from comment 4 against Ubuntu's metacity 2.34.1.  It did not stop metacity from crashing when I reproduced with the steps from comment 5.  :-/