After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603540 - g_time_val_from_iso8601 uses uninitialised variable
g_time_val_from_iso8601 uses uninitialised variable
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-12-01 23:15 UTC by Matthew W. S. Bell
Modified: 2009-12-09 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.14 KB, patch)
2009-12-01 23:15 UTC, Matthew W. S. Bell 		committed Details | Review

Description Matthew W. S. Bell 2009-12-01 23:15:31 UTC 
Created attachment 148867 [details] [review]
Patch

This function does not initialise the struct tm tm, giving it improper values of tm_isdst making the result an hour out. Here is a patch. It appears to have some whitespace changes in too; sorry.
Comment 1 Matthias Clasen 2009-12-01 23:28:25 UTC 
Comment on attachment 148867 [details] [review]
Patch

Patch looks good to me.
Comment 2 Javier Jardón (IRC: jjardon) 2009-12-02 00:52:57 UTC 
Comment on attachment 148867 [details] [review]
Patch

commit 2321e5aed07154761223bb124770beba56700e41
Comment 3 Javier Jardón (IRC: jjardon) 2009-12-02 00:57:45 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you Matthew for your bug report.
Comment 4 Matthew W. S. Bell 2009-12-09 20:36:59 UTC 
Is it not possible to distribute it in a minor/bugfix release?
Comment 5 Matthias Clasen 2009-12-09 20:39:33 UTC 
I'll pull it into a bugfix release, sure