After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603534 - Register enums and flags in PyGI if needed
Register enums and flags in PyGI if needed
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-01 22:01 UTC by Tomeu Vizoso
Modified: 2009-12-29 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Register enums and flags in PyGI if needed (2.14 KB, patch)
2009-12-01 22:01 UTC, Tomeu Vizoso 		reviewed Details | Review
Register enums and flags in PyGI if needed (2.74 KB, patch)
2009-12-29 12:10 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2009-12-01 22:01:17 UTC 
When a wrapper is required for the first time, it may need to be
registered by PyGI if it comes from a typelib.
Comment 1 Tomeu Vizoso 2009-12-01 22:01:19 UTC 
Created attachment 148863 [details] [review]
Register enums and flags in PyGI if needed
Comment 2 Gian Mario Tagliaretti 2009-12-25 16:18:27 UTC 
Tomeu I have no idea on how GI works, I didn't follow any of this part, if you and Simon think it's ok I guess you should commit.
Comment 3 Johan (not receiving bugmail) Dahlin 2009-12-29 11:31:04 UTC 
Review of attachment 148863 [details] [review]:

Looks good. Perhaps some comments could be added that explains the order/priority here.
Style wise it would be easier to follow without the indentation, eg:
pyclass = ...
if (!pyclass)
   pyclass = ...
if (!pyclass
    pyclass =
etc

Can commit with or without these changes
Comment 4 Tomeu Vizoso 2009-12-29 12:10:03 UTC 
Created attachment 150531 [details] [review]
Register enums and flags in PyGI if needed
Comment 5 Tomeu Vizoso 2009-12-29 12:10:38 UTC 
Attachment 150531 [details] pushed as 86783c6 - Register enums and flags in PyGI if needed