GNOME Bugzilla – Bug 603470
Do not abort if hal is not available
Last modified: 2010-01-18 10:13:13 UTC
Created attachment 148816 [details] [review] do not abort if hal is not installed g-p-m now runs sufficiently well without hal, so people who have working XBACKLIGHT (or don't care about missing notifications) should be able to uninstall hal. However, if you do this, g-p-m exits immediately. With attached patch, I can run g-p-m on a hal-less GNOME desktop.
I'm tempted to remove all the libhal-glib stuff, and remove the HAL brightness changing functionality completely. Or is that too drastic?
My gut feeling is that it's still a little too early for that, since xbacklight does not yet work on many hardware platforms. However, you probably have a better insight into which drivers would fall out of the "works" spectrum with this.
Created attachment 151414 [details] [review] do not connect to hal if xrandr is available Nowadays it is a valid setup to have hal installed, but only start on demand via D-Bus activation (instead of during boot). If we detect xrandr-capable hardware, do not try to connect to hal, to avoid triggering it. I tested this on a Dell Mini 10 (which does have XBACKLIGHT support), where hal is not triggered any more. I also tested it on my Dell Latitude D430, which doesn't have xrandr backlight support right now, and there hal is properly D-Bus activated and g-p-m backlight control/notification feedback works. Thanks for considering! Martin
Review of attachment 151414 [details] [review]: looks good, please commit.
Sebastien Bacher committed the patches for me, thanks for review!