GNOME Bugzilla – Bug 603423
Tomboy should make panel applet optional
Last modified: 2010-06-20 20:18:23 UTC
It would be lovely if Tomboy could be built without the panel applet, so that the heavy gnome-panel dependency is not drawn in. Would be very useful for all the places where you don't need the panel, like with GNOME Shell, other desktops, etc.
Agreed. Patches welcome; will make sure to get to this for GNOME 3.0, at least.
Created attachment 163984 [details] [review] Remove old compatibility code
Created attachment 163985 [details] [review] Make GNOME panel dependecy optional
Review of attachment 163985 [details] [review]: Both of these patches look really good. Some minor comments below. I do want to make sure we get the configure flag right, do you have any additional thoughts on it? ::: Tomboy/Tomboy.cs @@ +181,3 @@ // This will block if there is no existing instance running #if !WIN32 && !MAC +#if GNOME_PANEL You can remove the #if !WIN32 && !MAC line here. ::: configure.in @@ -152,0 +151,5 @@ +# +# Check for GNOME Panel Support +# ... 2 more ... What do you think is more easily understandable? --enable-gnome-panel, --enable-applet, or --enable-panel-applet ? @@ -369,2 +382,3 @@ D-Bus Support: ${ENABLE_DBUS} + GNOME Panel: ${ENABLE_GNOME_PANEL} I think s/"GNOME Panel"/"GNOME Panel Applet" would be helpful here.
Created attachment 164008 [details] [review] Make GNOME panel dependecy optional.v2 Use --enable-panel-applet instead
Comment on attachment 163984 [details] [review] Remove old compatibility code commit dcbbcbb6acade19853d190b7edf736c5a27d9fb8
I pushed a slightly modified version of Javier's patch: http://git.gnome.org/browse/tomboy/commit/?id=2aa928732b2835c64f04d2e605ca5a31591c7e5b