Bug 603324 - Search in URL bar broken when validating with ctrl+enter
Search in URL bar broken when validating with ctrl+enter
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] URL bar
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-11-29 18:48 UTC by Mathieu Bridon
Modified: 2009-11-30 14:03 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mathieu Bridon 2009-11-29 18:48:49 UTC 
1. type anything (that isn't a URL) in the URL bar and validate with enter
   => string is searched in google

2. type anything (that isn't a URL) in the URL bar and validate with ctrl+enter (to open a new tab)
   => Epiphany tries to open it as a URL and cannot resolve hostname (obviously)

Epiphany 2.28.1 on Fedora 12 x86_64
Comment 1 Xan Lopez 2009-11-29 18:58:46 UTC 
To fix this we need to fix ephy_web_view_load_request to do the same check we do in ephy_web_view_load_url to decide whether we want to search stuff in google or not, since when opening things in a new tab we use the former function, not the latter.
Comment 2 Xan Lopez 2009-11-30 14:03:10 UTC 
This is fixed in master, commit 2aca0c21a8f140a6d3b6bddfa4aed1b31326b1cd
Note You need to log in before you can comment on or make changes to this bug.