Bug 603301 – crash when cancelling creation of symlink by ESC

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 603301 - crash when cancelling creation of symlink by ESC


Summary:	crash when cancelling creation of symlink by ESC


Status:	RESOLVED FIXED

Product:	gnome-commander
Classification:	Other
Component:	application
Version:	1.2.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	1.2.9
Assigned To:	epiotr
QA Contact:	epiotr

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-11-29 14:48 UTC by Mamoru TASAKA
Modified:	2009-12-02 22:34 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
gdb log (15.28 KB, text/plain) 2009-11-29 14:48 UTC, Mamoru TASAKA		Details
Trial patch (888 bytes, patch) 2009-11-30 16:01 UTC, Mamoru TASAKA	none	Details \| Review

Description Mamoru TASAKA 2009-11-29 14:48:40 UTC

Created attachment 148688 [details]
gdb log

Description of / How to produce the problem

When
- launch gnome-commander
- choose File -> Create Symbolic link
- type ESC key
Then gnome-commander constantly crashes.

How reproducible:
100%

Component
gnome-commander-1.2.8.3-1.fc13.i686
gtk2-2.18.3-22.fc13.i686

Comment 1 Mamoru TASAKA 2009-11-29 14:50:25 UTC

The original report is
https://bugzilla.redhat.com/show_bug.cgi?id=542366
and this is reproducible to me.

Comment 2 Fabio Durán Verdugo 2009-11-29 15:23:07 UTC

I can confirm this 


Program received signal SIGABRT, Aborted.
0x007b6422 in __kernel_vsyscall ()
(gdb) bt full

+ Trace 219357

#0 __kernel_vsyscall
#1 *__GI_raise
at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
#2 *__GI_abort
at abort.c line 92
#3 __libc_message
at ../sysdeps/unix/sysv/linux/libc_fatal.c line 189
#4 malloc_printerr
at malloc.c line 6217
#5 _int_free
at malloc.c line 4750
#6 *__GI___libc_free
at malloc.c line 3716
#7 IA__g_free
at /build/buildd/glib2.0-2.22.2/glib/gmem.c line 190
#8 destroy
at gnome-cmd-dialog.c line 65
#9 destroy
at gnome-cmd-string-dialog.c line 83
#10 IA__g_cclosure_marshal_VOID__VOID
at /build/buildd/glib2.0-2.22.2/gobject/gmarshal.c line 77
#11 g_type_class_meta_marshal
at /build/buildd/glib2.0-2.22.2/gobject/gclosure.c line 878
#12 IA__g_closure_invoke
at /build/buildd/glib2.0-2.22.2/gobject/gclosure.c line 767
#13 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.22.2/gobject/gsignal.c line 3363
#14 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.22.2/gobject/gsignal.c line 2980
#15 IA__g_signal_emit
at /build/buildd/glib2.0-2.22.2/gobject/gsignal.c line 3037
#16 gtk_object_dispose
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkobject.c line 421
#17 gtk_widget_dispose
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkwidget.c line 8370
#18 gtk_window_dispose
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkwindow.c line 2151
#19 IA__g_object_unref
at /build/buildd/glib2.0-2.22.2/gobject/gobject.c line 2441
#20 IA__gtk_propagate_event
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmain.c line 2431
#21 IA__gtk_main_do_event
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmain.c line 1622
#22 gdk_event_dispatch
at /build/buildd/gtk+2.0-2.18.3/gdk/x11/gdkevents-x11.c line 2369
#23 g_main_dispatch
at /build/buildd/glib2.0-2.22.2/glib/gmain.c line 1960
#24 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.22.2/glib/gmain.c line 2513
#25 g_main_context_iterate
at /build/buildd/glib2.0-2.22.2/glib/gmain.c line 2591
#26 IA__g_main_loop_run
at /build/buildd/glib2.0-2.22.2/glib/gmain.c line 2799
#27 IA__gtk_main
at /build/buildd/gtk+2.0-2.18.3/gtk/gtkmain.c line 1218
#28 main
at main.cc line 146

Comment 3 Mamoru TASAKA 2009-11-30 16:01:02 UTC

Created attachment 148759 [details] [review]
Trial patch

There may be some better solution (as I don't know well the coding
of gcmd), the attached patch seems to work for me.

Comment 4 epiotr 2009-12-02 22:34:00 UTC

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.