After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603152 - Use libcanberra instead of GStreamer for shutter
Use libcanberra instead of GStreamer for shutter
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 2.28
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
: 546929 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-27 15:34 UTC by Bastien Nocera
Modified: 2009-11-30 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use libcanberra instead of GStreamer for shutter (10.93 KB, patch)
2009-11-27 15:34 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2009-11-27 15:34:49 UTC 
Removes code, removing code is good!
Comment 1 Bastien Nocera 2009-11-27 15:34:51 UTC 
Created attachment 148600 [details] [review]
Use libcanberra instead of GStreamer for shutter
Comment 2 Filippo Argiolas 2009-11-30 19:03:55 UTC 
Review of attachment 148600 [details] [review]:

Looks fine to me. Daniel?
There is another patch in bug 546929 but this seems better, see inline comment (I just wanted to test splinter since I had no chance to do it yet ;-))

::: src/cheese-window.c
@@ +1285,3 @@
     shutter_filename = audio_play_get_filename (cheese_window);
+    ca_gtk_play_for_widget (cheese_window->screen, 0,
+			    CA_PROP_MEDIA_FILENAME, shutter_filename,

We have another patch waiting in bugzilla that uses "camera-shutter event". I suppose this would be better since it lets us use our beloved shutter sounds, Daniel?
Comment 3 Bastien Nocera 2009-11-30 19:42:09 UTC 
This could be applied, and then switched to using the camera-shutter event sound when it's actually available.
Comment 4 daniel g. siegel 2009-11-30 22:58:57 UTC 
*** Bug 546929 has been marked as a duplicate of this bug. ***
Comment 5 daniel g. siegel 2009-11-30 22:59:31 UTC 
i removed our files, as i even wasnt sure about the copyright of the shutter sound. the camera-shutter event sound is already available since a few months.

commit b7a59578b99016a79e613f8bb69f5b5e455258bb
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Nov 27 15:33:54 2009 +0000

    Use libcanberra instead of GStreamer for shutter
⋅⋅⋅⋅
    https://bugzilla.gnome.org/show_bug.cgi?id=603152