After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603068 - Undefined references when linking wizard/test-input
Undefined references when linking wizard/test-input
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: wizard
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-11-26 17:55 UTC by Jürg Billeter
Modified: 2009-11-27 02:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch: Require xi for wizard (547 bytes, patch)
2009-11-26 17:55 UTC, Jürg Billeter
none Details | Review
Fix building input helper when GTK+ has no xi support (1.48 KB, patch)
2009-11-27 02:52 UTC, Bastien Nocera
committed Details | Review

Description Jürg Billeter 2009-11-26 17:55:03 UTC
Created attachment 148545 [details] [review]
Patch: Require xi for wizard

I get this when trying to build 2.29.2:

  CCLD   test-input
bluetooth-input.o: In function `bluetooth_input_check_for_devices':
/usr/src/gnome-bluetooth-2.29.2/wizard/bluetooth-input.c:182: undefined reference to `XListInputDevices'
/usr/src/gnome-bluetooth-2.29.2/wizard/bluetooth-input.c:207: undefined reference to `XFreeDeviceList'
bluetooth-input.o: In function `devicepresence_filter':
/usr/src/gnome-bluetooth-2.29.2/wizard/bluetooth-input.c:219: undefined reference to `_XiGetDevicePresenceNotifyEvent'
bluetooth-input.o: In function `set_devicepresence_handler':
/usr/src/gnome-bluetooth-2.29.2/wizard/bluetooth-input.c:239: undefined reference to `_XiGetDevicePresenceNotifyEvent'
/usr/src/gnome-bluetooth-2.29.2/wizard/bluetooth-input.c:240: undefined reference to `XSelectExtensionEvent'
collect2: ld returned 1 exit status
make[2]: *** [test-input] Error 1

xi appears to be missing in the pkg-config check in configure.ac. The attached patch fixes that.
Comment 1 Bastien Nocera 2009-11-27 02:48:58 UTC
Could you attach a git formatted patch so that the authorship isn't lost?
Comment 2 Bastien Nocera 2009-11-27 02:52:40 UTC
Created attachment 148571 [details] [review]
Fix building input helper when GTK+ has no xi support
Comment 3 Bastien Nocera 2009-11-27 02:53:20 UTC
Fixed slightly differently in master, thanks.

Attachment 148571 [details] pushed as 4662dfd - Fix building input helper when GTK+ has no xi support