After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603038 - InitiallyUnownedClass should contain all the fields as ObjectClass if we want offset counting to be correct in its sublasses
InitiallyUnownedClass should contain all the fields as ObjectClass if we want...
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-11-26 11:45 UTC by Tomeu Vizoso
Modified: 2015-02-07 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
InitiallyUnownedClass should contain all the fields as ObjectClass if we want offset counting to be correct in its sublasses (1.00 KB, patch)
2009-11-26 11:46 UTC, Tomeu Vizoso
committed Details | Review

Description Tomeu Vizoso 2009-11-26 11:45:59 UTC
Hacky patch attached, suggestions welcome.
Comment 1 Tomeu Vizoso 2009-11-26 11:46:03 UTC
Created attachment 148522 [details] [review]
InitiallyUnownedClass should contain all the fields as ObjectClass if we want offset counting to be correct in its sublasses
Comment 2 Colin Walters 2009-11-30 15:48:35 UTC
Hmm there is already code to do this, see the special handling in _parse_get_type_function:

if (self._namespace_name == 'GObject' and
            symbol in ('g_object_get_type', 'g_initially_unowned_get_type')):

and _create_gobject has code to copy fields.
Comment 3 Colin Walters 2009-11-30 16:13:01 UTC
Review of attachment 148522 [details] [review]:

I see, this is for the class struct.  You might want to note we're doing the same thing for the instance structs in _create_gobject.
Comment 4 Colin Walters 2009-11-30 16:13:01 UTC
Review of attachment 148522 [details] [review]:

I see, this is for the class struct.  You might want to note we're doing the same thing for the instance structs in _create_gobject.
Comment 5 Tomeu Vizoso 2009-11-30 16:19:42 UTC
Attachment 148522 [details] pushed as 1020622 - InitiallyUnownedClass should contain all the fields as ObjectClass if we want offset counting to be correct in its sublasses
Comment 6 André Klapper 2015-02-07 16:52:37 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]