After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603004 - Exporting a document to png without --size crashes dia
Exporting a document to png without --size crashes dia
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: exports
0.97
Other Linux
: Normal major
: 0.97.1
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-26 06:51 UTC by Huzaifa Sidhpurwala (Red Hat Security Response)
Modified: 2009-11-28 21:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backtrace (19.70 KB, text/plain)
2009-11-26 06:51 UTC, Huzaifa Sidhpurwala (Red Hat Security Response) 		  Details
avoid dialog creation on non-interactive use (1.21 KB, patch)
2009-11-26 21:34 UTC, Hans Breuer 		none Details | Review

Description Huzaifa Sidhpurwala (Red Hat Security Response) 2009-11-26 06:51:03 UTC 
Created attachment 148506 [details]
backtrace

OS: Fedora 12 , fully updated.
Dia version: 0.97

Exporting a file to png without --size as:
dia --export=image.png --filter=png --nosplash image.dia
will result in a crash, the gdb crash log is attached.

However if i use --size as:
dia --export=image.png --filter=png --nosplash --size=100x100 image.dia
it seems to work.

Distro bug: https://bugzilla.redhat.com/show_bug.cgi?id=541319

Note: I am the Fedora maintainer for dia.

It seems this problem was fixed in 0.91 and hence looks like a regression.
Comment 1 Hans Breuer 2009-11-26 21:34:56 UTC 
Created attachment 148552 [details] [review]
avoid dialog creation on non-interactive use

The so called regression bug #81367 is only 7 years old and at first glance has nothing to do with this crash. 
This one results from unconditional use of GUI code in plug-ins/libart/export_png.c(export_png) - the attached patch should fix it, but is not yet tested on X11.
Comment 2 Huzaifa Sidhpurwala (Red Hat Security Response) 2009-11-27 06:53:09 UTC 
This works for me, Thanks.
Will this be committed to the latest tree?
Comment 3 Hans Breuer 2009-11-28 21:27:51 UTC 
Yes. And to dia-0-97:

commit 5e649eb8976140cc7decd7af95c77aeb3418b960
Author: Hans Breuer <hans@breuer.org>
Date:   Fri Nov 27 22:47:45 2009 +0100

    Bug 603004 - Exporting a document to png without --size crashes

    Only show the size dialog when running interactive. Introduces a dependencies to app/ but crashing is worse.
    (cherry picked from commit 93f1efad1e0336da83bd3789a0c8e505b0daac6c)