After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602958 - Right click over source in calendar view opens a calendar
Right click over source in calendar view opens a calendar
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.30.x (obsolete)
Other Linux
: Low normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[regression]
Depends on:
Blocks:
 
 
Reported: 2009-11-25 16:51 UTC by Milan Crha
Modified: 2010-11-12 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
eds patch (554 bytes, patch)
2010-11-12 09:34 UTC, Milan Crha 		committed Details | Review

Description Milan Crha 2009-11-25 16:51:26 UTC 
Right click over a calendar in a calendar view opens a calendar. i think it didn't do that before kill-bonobo. Note that I right-clicked on a source which was a primary source already, and which was opened.
The trace of the right-click without boring parts:

+ Trace 219284

Thread 1 (Thread 0xb7f7b770 (LWP 17482))

  • #9 dbus_g_proxy_call
    at dbus-gproxy.c line 2593
  • #10 org_gnome_evolution_dataserver_calendar_CalFactory_get_cal
    at e-data-cal-factory-bindings.h line 32
  • #11 e_cal_new
    at e-cal.c line 808
  • #12 auth_new_cal_from_source
    at authentication.c line 113
  • #13 gnome_calendar_set_default_source
    at gnome-cal.c line 2284
  • #14 cal_shell_view_selector_primary_changed_cb
    at e-cal-shell-view-private.c line 284
  • #19 g_signal_emit
    from /lib/libgobject-2.0.so.0
  • #20 selection_changed_callback
    at e-source-selector.c line 666
  • #28 gtk_tree_selection_select_iter
    from /usr/lib/libgtk-x11-2.0.so.0
  • #29 e_source_selector_set_primary_selection
    at e-source-selector.c line 1600
  • #30 selector_button_press_event
    at e-source-selector.c line 765
  • #42 g_main_loop_run
    from /lib/libglib-2.0.so.0
  • #43 gtk_main
    from /usr/lib/libgtk-x11-2.0.so.0
  • #44 main
    at main.c line 621 






Comment 1


Matthew Barnes





          2009-12-20 14:30:25 UTC
        



I don't understand what this is about.  Can you give more exact steps?






Comment 2


Milan Crha





          2009-12-21 09:45:32 UTC
        



Sure. I guess the easiest way is to add a remote calendar and do not mark it for offline use. Then go to offline and select the calendar. You'll be prompted about "not being marked for offline". That's OK. But it tells you that also on each right click over this calendar, before the popup menu is shown.

It does the same when you've a calendar which requires authentication and you didn't give it a password yet. You are asked for the password.

It does it with other calendars as well, but in those two cases it's visually noticeable. I believe it shouldn't open a calendar on right click, because it can take some time with remote calendars. And it should open it especially when it is already opened.






Comment 3


Matthew Barnes





          2010-01-11 14:42:58 UTC
        



(In reply to comment #2)
> Sure. I guess the easiest way is to add a remote calendar and do not mark it
> for offline use. Then go to offline and select the calendar. You'll be prompted
> about "not being marked for offline". That's OK.

Okay, I'm able to reproduce this much.

> But it tells you that also on each right click over this calendar, before the popup
> menu is shown.

But not this part.  Whether the calendar is checkmarked or not while offline, right-clicking on it shows the popup menu without any error dialog.  I'm testing with my Zimbra CalDAV calendar.

Are you still seeing this?






Comment 4


Matthew Barnes





          2010-01-11 14:49:10 UTC
        



As a related but separate issue, calendars (or any other type of ESource) whose content is not available while offline should probably be desensitized in the source selector tree in offline mode so it's obvious that you can't interact with the calendar at all.  That would eliminate a couple lame error dialogs.






Comment 5


Milan Crha





          2010-01-11 16:02:09 UTC
        



Maybe some changes in EAlert and such are preventing to show the dialog, but on the console are still shown
> calendar-gui-WARNING **: Unable to load the calendar Repository is offline
on every right click of the similar calendar you are using.






Comment 6


Matthew Barnes





          2010-01-11 18:39:39 UTC
        



Hmm.  Since I'm not seeing this could you post a backtrace from where that warning is emitted?






Comment 7


Milan Crha





          2010-01-12 10:02:46 UTC
        



This is when I right click over the CalDAV calendar in offline:

Breakpoint 1, IA__g_logv (log_domain=0x7f40963a1392 "calendar-gui", log_level=G_LOG_LEVEL_WARNING, format=0x7f40963a18b0 "Unable to load the calendar %s \n",
    args1=0x7fffa96e5d00) at gmessages.c:431
431       gboolean was_fatal = (log_level & G_LOG_FLAG_FATAL) != 0;
(gdb) bt




+
Trace
    220018






    

  • 
#0
IA__g_logv

    
                at gmessages.c
                  line
                  431

    

    • 

  • 
#1
IA__g_log

    
                at gmessages.c
                  line
                  569

    

    • 

  • 
#2
default_client_cal_opened_cb

    
                at gnome-cal.c
                  line
                  2008

    

    • 

  • 
#3
IA__g_cclosure_marshal_VOID__INT

    
                at gmarshal.c
                  line
                  216

    

    • 

  • 
#4
IA__g_closure_invoke

    
                at gclosure.c
                  line
                  767

    

    • 

  • 
#5
signal_emit_unlocked_R

    
                at gsignal.c
                  line
                  3247

    

    • 

  • 
#6
IA__g_signal_emit_valist

    
                at gsignal.c
                  line
                  2980

    

    • 

  • 
#7
IA__g_signal_emit

    
                at gsignal.c
                  line
                  3037

    

    • 

  • 
#8
async_signal_idle_cb

    
                at e-cal.c
                  line
                  1100

    

    • 

  • 
#9
org_gnome_evolution_dataserver_calendar_Cal_open_async_callback

    
                at e-data-cal-bindings.h
                  line
                  81

    

    • 

  • 
#10
complete_pending_call_and_unlock

    
                at dbus-connection.c
                  line
                  2212

    

    • 

  • 
#11
dbus_connection_dispatch

    
                at dbus-connection.c
                  line
                  4352

    

    • 

  • 
#12
message_queue_dispatch

    
                at dbus-gmain.c
                  line
                  101

    

    • 

  • 
#13
g_main_dispatch

    
                at gmain.c
                  line
                  1960

    

    • 

  • 
#14
IA__g_main_context_dispatch

    
                at gmain.c
                  line
                  2513

    

    • 

  • 
#15
g_main_context_iterate

    
                at gmain.c
                  line
                  2591

    

    • 

  • 
#16
IA__g_main_loop_run

    
                at gmain.c
                  line
                  2799

    

    • 

  • 
#17
IA__gtk_main

    
                at gtkmain.c
                  line
                  1219

    

    • 

  • 
#18
main

    
                at main.c
                  line
                  609

    

    • 













Comment 8


Matthew Barnes





          2010-02-06 19:26:55 UTC
        



Milan, can you retest this with 2.29.90 or later?  I did a bunch of work on sidebar / ECalModel interaction a couple weeks ago so this may well be fixed now.






Comment 9


Milan Crha





          2010-02-08 13:06:54 UTC
        



I'm sorry, it's still there.






Comment 10


Milan Crha





          2010-11-12 09:34:41 UTC
        



Created attachment 174312 [details] [review]
eds patch

for evolution-data-server;

ESourceSelector did it, invoking the "primary-source-changed" signal on every click by calling e_source_selector_set_primary_selection unconditionally.






Comment 11


Milan Crha





          2010-11-12 09:36:34 UTC
        



Created commit 704ca40 in eds master (2.91.3+)