GNOME Bugzilla – Bug 602951
share bar finetuning
Last modified: 2019-03-20 10:39:01 UTC
Previously reported here: - Currently the share bar doesn't differentiate between enabled and disabled. Imo, the messages should be slightly different. If sharing is disabled, the message should be as it is currently: "You can share files from this folder..." But if sharing is enabled, the message should be something like: "Files in this folder are shared..." And you had some concerns: We can't fix the second part. It's easy if you have 3 different folders for ObexPush, ObexFTP and DAVS sharing. But it gets more complicated when you need to tell the user that: You can share files from this folder using HTTP, this folder is already shared using ObexFTP over Bluetooth. And what do we show when the public directory is the same as the downloads directory? Ideas welcome, in a separate bug... Here are some ideas: - I don't think details about the individual transports need to be shown in the share bar message. - If sharing is disabled, you want to tell the user that it can be turned on, mostly: You can receive files from other users in this folder [ Launch Preferences ] You can share files from this folder with other users [ Launch Preferences ] seem both fine to me. - If sharing is enabled, we need to tell users that the files they see in Public can be seen by others. Files received from other users will be placed here [ Launch Preferences ] Files in this folder are visible to others [ Launch Preferences ]
I meant to say Previously reported here: https://bugzilla.gnome.org/show_bug.cgi?id=600499
Also worth pointing out that the annoyance factor of the message is probably to a large part due to the bar and thus the button being slightly too large, due to two-line text. Another small annoyance: the first line is regular, the second line italic. Removing the 'Personal File Sharing' in the first line would solve both of these.
I think the current amount of text and the annoyance is acceptable as a notification, but that requires that there is a simple way to turn it off. I would assume that this file sharing preferences menu is available somewhere in the menu too, but I can't find it? "Launch Preferences" in this context hints that it is Edit/Preferences. "Launch Personal File Sharing Preferences" would be more descriptive ... but probably too verbose.
Created attachment 157833 [details] [review] gnome-user-share-share-bar-check.patch This is a patch against Gnome 2.28 in Fedora 12 from the Red Hat bugzilla report: https://bugzilla.redhat.com/show_bug.cgi?id=539586 It adds a preference toggle to the Gnome User Share settings window to turn on/off the share bar text. The first patch creates a checkbox in the preferences and a boolean in the schema.
Created attachment 157834 [details] [review] gnome-user-share-share-extension.patch The second patch adds the boolean check to the share-extension.c module. The other folder bars (Public, etc.) could be added using my patches as a template.
I don't agree at all with the solution of adding a configuration option.
See also bug 613584 for the specific case of always showing the bar in the Downloads folder.
(In reply to comment #6) > I don't agree at all with the solution of adding a configuration option. The bar takes up valuable folder display space. Why must I be *constantly* reminded that the Downloads folder is where Downloads go? Redundant crap if I've ever seen it. How did this feature get added by some random person's suggestion, yet to add a configurable option (user toggled or otherwise) is dismissed immediately? What will be appropriate to satisfy everyone? I'm ready and willing to write a patch. I just missed getting on the CC list on this bug somehow.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-user-share/issues/17.