After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602909 - Always show icons for Create Document submenu
Always show icons for Create Document submenu
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-25 08:52 UTC by Luca Ferretti
Modified: 2012-08-16 02:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make templates and scripts menus show icons (5.19 KB, patch)
2012-08-14 20:17 UTC, William Jon McCann
none Details | Review
Make templates and scripts menus show icons (4.19 KB, patch)
2012-08-15 14:45 UTC, William Jon McCann
reviewed Details | Review
Make templates and scripts menus show icons (4.25 KB, patch)
2012-08-15 22:23 UTC, William Jon McCann
committed Details | Review

Description Luca Ferretti 2009-11-25 08:52:40 UTC
Now that GNOME has switched to no-menu-icon default, to match guidelines[1] Nautilus should enable "always show" properties for entries in Create Document submenu.

The lack of icons here is an usability issue: there is no way to identify the file type you are going to create, due the strip of file name extension.


[1] documents, bookmarks, applications, and devices.
Comment 1 Allan Day 2010-06-25 13:00:57 UTC
Makes sense.
Comment 2 William Jon McCann 2012-08-14 20:17:44 UTC
Created attachment 221189 [details] [review]
Make templates and scripts menus show icons
Comment 3 William Jon McCann 2012-08-15 14:45:01 UTC
Created attachment 221269 [details] [review]
Make templates and scripts menus show icons
Comment 4 Cosimo Cecchi 2012-08-15 18:10:54 UTC
Review of attachment 221269 [details] [review]:

Looks good, thanks!
Comment 5 Cosimo Cecchi 2012-08-15 18:12:36 UTC
Review of attachment 221269 [details] [review]:

Missed a couple of things, sorry.

::: src/nautilus-view.c
@@ +5254,3 @@
 	pixbuf = get_menu_icon_for_file (file);
 	if (pixbuf != NULL) {
+		gtk_action_set_gicon (action, G_ICON (pixbuf));

I think you have to unref the pixbuf here...

@@ +5507,3 @@
 	pixbuf = get_menu_icon_for_file (file);
 	if (pixbuf != NULL) {
+		gtk_action_set_gicon (action, G_ICON (pixbuf));

...and here.
Comment 6 William Jon McCann 2012-08-15 22:23:44 UTC
Created attachment 221325 [details] [review]
Make templates and scripts menus show icons
Comment 7 Cosimo Cecchi 2012-08-16 01:44:04 UTC
Review of attachment 221325 [details] [review]:

Looks good