GNOME Bugzilla – Bug 602909
Always show icons for Create Document submenu
Last modified: 2012-08-16 02:01:04 UTC
Now that GNOME has switched to no-menu-icon default, to match guidelines[1] Nautilus should enable "always show" properties for entries in Create Document submenu. The lack of icons here is an usability issue: there is no way to identify the file type you are going to create, due the strip of file name extension. [1] documents, bookmarks, applications, and devices.
Makes sense.
Created attachment 221189 [details] [review] Make templates and scripts menus show icons
Created attachment 221269 [details] [review] Make templates and scripts menus show icons
Review of attachment 221269 [details] [review]: Looks good, thanks!
Review of attachment 221269 [details] [review]: Missed a couple of things, sorry. ::: src/nautilus-view.c @@ +5254,3 @@ pixbuf = get_menu_icon_for_file (file); if (pixbuf != NULL) { + gtk_action_set_gicon (action, G_ICON (pixbuf)); I think you have to unref the pixbuf here... @@ +5507,3 @@ pixbuf = get_menu_icon_for_file (file); if (pixbuf != NULL) { + gtk_action_set_gicon (action, G_ICON (pixbuf)); ...and here.
Created attachment 221325 [details] [review] Make templates and scripts menus show icons
Review of attachment 221325 [details] [review]: Looks good