After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602772 - Close button disappears when zooming in overview
Close button disappears when zooming in overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-23 20:17 UTC by Raphael Freudiger
Modified: 2009-11-25 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[workspaces] Fix disappearing close button (1.09 KB, patch)
2009-11-23 21:42 UTC, Florian Müllner
reviewed Details | Review
[workspaces] Fix disappearing close button (1.06 KB, patch)
2009-11-24 00:35 UTC, Florian Müllner
committed Details | Review

Description Raphael Freudiger 2009-11-23 20:17:39 UTC
When hover mouse over a window in overview mode a close button shows up. But when zooming in the window it disappears. Also after zooming out again it does not show up again. After moving mouse away from the window and back to it the button shows up again.
Expected: Close button should be visible during zooming window in overview mode or at least show up again after zooming out again.
Comment 1 Florian Müllner 2009-11-23 21:42:56 UTC
Created attachment 148349 [details] [review]
[workspaces] Fix disappearing close button

Show the close button after zooming a window in the overview when the
window clone has the pointer focus.
Comment 2 Colin Walters 2009-11-24 00:26:01 UTC
Review of attachment 148349 [details] [review]:

::: js/ui/workspaces.js
@@ +371,3 @@
+                                                  x, y);
+        let actor = global.stage.get_actor_at_pos(Clutter.PickMode.REACTIVE,
+        let [child, x, y, mask] = Gdk.Screen.get_default().get_root_window().get_pointer();

If the close button isn't visible now, you're not going to pick it up from get_actor_at_pos, so the "actor == this.closeButton" is superfulous.
Comment 3 Florian Müllner 2009-11-24 00:35:47 UTC
Created attachment 148357 [details] [review]
[workspaces] Fix disappearing close button

Show the close button after zooming a window in the overview when the
window clone has the pointer focus.
Comment 4 Colin Walters 2009-11-24 00:37:27 UTC
Review of attachment 148357 [details] [review]:

Looks good, thanks!
Comment 5 Gustavo Noronha (kov) 2009-11-25 21:17:40 UTC
This seems to have been committed as f0e3b87330a542bfe8a9331bf880a952a31abea8.