After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602753 - Make it possible to build plugins out-of-tree
Make it possible to build plugins out-of-tree
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 623247
Blocks:
 
 
Reported: 2009-11-23 17:25 UTC by Josselin Mouette
Modified: 2011-01-14 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
install pkg-config and header files (5.00 KB, patch)
2010-05-16 13:16 UTC, Simon Wenner
rejected Details | Review

Description Josselin Mouette 2009-11-23 17:25:11 UTC
It would be nice if some C totem plugins could be built separately from the main tarball, as e.g. epiphany or eog allow. This implies installing a selected list of headers, and adding a pkg-config file.

The reason why I am asking is that the youtube plugin needs to be handled a special way in stable distributions releases. Every time the Youtube API changes, we need to update the plugin. However it is a pain to update the whole totem package just for that effect. Being able to build plugins separately would make it possible for us to ship a tarball including only this plugin.
Comment 1 Götz Waschk 2010-02-17 17:21:18 UTC
Add the Vala .vapi file to this.
Comment 2 Simon Wenner 2010-05-16 13:16:30 UTC
Created attachment 161167 [details] [review]
install pkg-config and header files

Patch to install a totem pkg-config file, the vala bindings (vapi) and the following header files:

totem.h
totem-plugin.h
totem-cell-renderer-video.h
totem-video-list.h
totem-playlist.h
bacon-video-widget.h

Most of the plugins use these symbols, but I'm not sure if additional header files should be installed.
Comment 3 Philip Withnall 2010-06-27 17:01:20 UTC
Done in http://git.gnome.org/browse/totem/log/?h=introspection.
Comment 4 Philip Withnall 2010-06-30 21:15:24 UTC
commit 567558c62a5df85795bbcb2ceb79604e58cb20fb
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Jun 26 23:39:13 2010 +0100

    Bug 602753 — Make it possible to build plugins out-of-tree
    
    Install a limited set of headers for plugins to use, plus a pkg-config file.
    Closes: bgo#602753

 configure.in     |   12 ++++++++++++
 data/Makefile.am |    4 ++++
 data/totem.pc.in |   11 +++++++++++
 src/Makefile.am  |    4 ++++
 4 files changed, 31 insertions(+), 0 deletions(-)
Comment 5 Philip Withnall 2010-06-30 21:15:52 UTC
Comment on attachment 161167 [details] [review]
install pkg-config and header files

Outdated.

We don't install the VAPI file yet, but Vala support for plugins is still broken.
Comment 6 Philip Withnall 2011-01-14 18:42:45 UTC
Vala no longer requires VAPI files, and since Totem installs its GIR file, I think this bug can be closed as fixed.