After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602664 - Should not install the server in $(bindir)
Should not install the server in $(bindir)
Status: RESOLVED OBSOLETE
Product: libgtop
Classification: Core
Component: general
2.28.x
Other FreeBSD
: Normal minor
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-22 20:29 UTC by Josselin Mouette
Modified: 2018-01-10 19:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Install libgtop_server2 in $(libexecdir) (3.33 KB, patch)
2009-11-22 20:29 UTC, Josselin Mouette 		none Details | Review
install to libexecdir, not bindir (3.61 KB, patch)
2016-01-29 10:40 UTC, David King 		none Details | Review

Description Josselin Mouette 2009-11-22 20:29:32 UTC 
Created attachment 148293 [details] [review]
Install libgtop_server2 in $(libexecdir)

The libgtop_server2 binary is launched by the library itself, and has no use being launched directly. Therefore, it should go in $(libexecdir) instead.

The patch also adds some missing $(DESTDIR) references in the installation hooks.
Comment 1 Robert Roth 2013-08-24 11:06:11 UTC 
Review of attachment 148293 [details] [review]:

Unfortunately this patch breaks JHBuilding the module, it would be nice if you could submit an updated patch.
Comment 2 David King 2016-01-29 10:40:46 UTC 
Created attachment 320009 [details] [review]
install to libexecdir, not bindir

This is an updated copy of the original patch. This installs just fine in jhbuild for me  (on Linux, where there is no server). If it breaks on one of the platforms where this is required, we need to know what the failure is so that it can be fixed.
Comment 3 Benoît Dejean 2016-02-15 19:34:59 UTC 
I know I am probably the only user of libgtop_daemon2, so let's forget about it.
I'm fine with the latest patch, it runs fine on FreeBSD.
Comment 4 GNOME Infrastructure Team 2018-01-10 19:47:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgtop/issues/17.