After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602615 - rhythmbox fails to build if python bindings are built and ld's --no-add-needed is used
rhythmbox fails to build if python bindings are built and ld's --no-add-neede...
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-22 03:01 UTC by Emilio Pozuelo Monfort
Modified: 2009-11-22 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Link against python if building the python bindings (668 bytes, patch)
2009-11-22 03:03 UTC, Emilio Pozuelo Monfort
none Details | Review

Description Emilio Pozuelo Monfort 2009-11-22 03:01:25 UTC
Hi,

With ld's --no-add-needed flag used (which is used by default in gold), rhythmbox fails to build if the python bindings are being built. The attached trivial patch solves the issue for me.

http://bugs.debian.org/556320
http://wiki.debian.org/qa.debian.org/FTBFS#A2009-11-02Packagesfailingbecausebinutils-gold.2BAC8-indirectlinking


/bin/bash ../libtool  --tag=CC   --mode=link cc  -g -O2 -g -Wall -O2  -export-dynamic -no-undefined  -o rhythmbox main.o librhythmbox-core.la -ltotem-plparser -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lgio-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0   -lgnome-media-profiles -lgconf-2 -lglade-2.0 -lgtk-x11-2.0 -lxml2 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lsoup-gnome-2.4 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0   -pthread -lgstbase-0.10 -lgstreamer-0.10 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lxml2 -lglib-2.0   -ldbus-glib-1 -ldbus-1 -lpthread -lrt -lgobject-2.0 -lglib-2.0   -lz 
libtool: link: cc -g -O2 -g -Wall -O2 -o .libs/rhythmbox main.o -pthread -Wl,--export-dynamic  ./.libs/librhythmbox-core.so -ltotem-plparser -lgnome-media-profiles /usr/lib/libgconf-2.so /usr/lib/libglade-2.0.so /usr/lib/libgtk-x11-2.0.so /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libpangoft2-1.0.so /usr/lib/libgdk_pixbuf-2.0.so -lm /usr/lib/libpangocairo-1.0.so /usr/lib/libcairo.so /usr/lib/libpango-1.0.so /usr/lib/libfreetype.so -lfontconfig -lsoup-gnome-2.4 -lsoup-2.4 /usr/lib/libgio-2.0.so /usr/lib/libgstbase-0.10.so /usr/lib/libgstreamer-0.10.so /usr/lib/libgmodule-2.0.so /usr/lib/libgthread-2.0.so /usr/lib/libxml2.so -ldbus-glib-1 -ldbus-1 -lpthread -lrt /usr/lib/libgobject-2.0.so /usr/lib/libglib-2.0.so -lz -pthread
/usr/bin/ld: main.o: in function main:main.c:334: error: undefined reference to 'PyEval_RestoreThread'
/usr/bin/ld: main.o: in function main:main.c:330: error: undefined reference to 'PyEval_SaveThread'
collect2: ld returned 1 exit status
make[4]: *** [rhythmbox] Error 1
Comment 1 Emilio Pozuelo Monfort 2009-11-22 03:03:32 UTC
Created attachment 148256 [details] [review]
Link against python if building the python bindings
Comment 2 Jonathan Matthew 2009-11-22 08:21:33 UTC
committed, thanks.