GNOME Bugzilla – Bug 602577
Popup blocking is broken
Last modified: 2016-01-13 04:28:15 UTC
Attempting to uncheck "Popup Windows" under View in the menu doesn't work. The item remains checked. This is under Ubuntu 9.10 Karmic (32-bit) and Epiphany 2.29.1 using both the Webkit and Epiphany PPA repositories.
Confirmed.
This happens because the methods of ephy-embed-single.c are not yet implemented. In this case, the method impl_permission_manager_test returns always return (EphyPermission)0; That would be EPHY_PERMISSION_ALLOWED, so it's always TRUE. That's why the item remains checked.
(In reply to comment #2) > This happens because the methods of ephy-embed-single.c are not yet > implemented. > In this case, the method impl_permission_manager_test returns always > > return (EphyPermission)0; > > That would be EPHY_PERMISSION_ALLOWED, so it's always TRUE. That's why the item > remains checked. That's right, although changing the hardcoded value to something else wouldn't fix the problem (DENIED would make the checkbox always unticked, and DEFAULT would make the checkbox always have the value of the gconf key for popups). Basically the whole feature needs to be reimplemented again.
Didn't we discuss this during the hackfest? It seems clear to me that reinstating the old behavior is not the way to go. For a discussion, see bug 339545. If this bug cannot be properly fixed before 2.30, I vote for completely removing the item for the View menu and just have the global preference for now.
(In reply to comment #4) > Didn't we discuss this during the hackfest? > > It seems clear to me that reinstating the old behavior is not the way to go. > For a discussion, see bug 339545. > > If this bug cannot be properly fixed before 2.30, I vote for completely > removing the item for the View menu and just have the global preference for > now. IIRC what was under discussion was the UI and its awkwardness, the implementation will be pretty much identical however we choose to show it to users.
Change the title to reflect what's actually happening. We don't even have UI for this now, only broken code in embed/ Should be high priority for 3.6.
A possible solution would be to: - only block automatic pop-ups, not ones that come form user interaction (I understand that we already do this), - allow a whitelist of sites that are allowed to launch pop-ups, - notify the user when pop-ups have been blocked. We could display an in-app notification [1] when a pop-up is blocked, allowing the user to: - review and launch the blocked pop-ups, - add the current site to the whitelist, - dismiss the notification, - *maybe* turn off notifications altogether (in which case there should be an option to turn them on again). Something to consider is if, besides the notification itself, there could be a small indicator somewhere else in the UI. Firefox and Chrome, for instance, display a small icon inside the URL field. However, this field will be hidden in Epiphany [2] so a different solution would be needed (pretty useless to have an indicator about the current page that is only displayed when the user wants to enter a URL to go to a different page). This is just a small proposal that is similar to the way desktop browsers work; mobile browsers are much more aggressive when blocking pop-ups. E.g. on the N9, the default browser and Opera block almost everything on popuptest.com without any notification at all, whereas Firefox Mobile shows a banner with actions for "Show", "Always show", "Never Show" and dismiss. [1] : https://github.com/gnome-design-team/gnome-mockups/raw/master/documents/documents-notifications.png [2] : https://live.gnome.org/Design/Apps/Web
(In reply to michael de from comment #0) > Attempting to uncheck "Popup Windows" under View in the menu doesn't work. > The item remains checked. Well that's definitely not a problem anymore. Anything still wrong here?
Hi, I am closing all Epiphany bugs currently in the NEEDINFO state. If you can provide the requested information or you feel this bug was closed in error, please leave a comment. Thanks!