After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602465 - gst/dtmf/tone_detect.h incompatible with MSVC
gst/dtmf/tone_detect.h incompatible with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.17
Other Windows
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-20 01:06 UTC by David Hoyt
Modified: 2009-11-20 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes tone_detect.h (556 bytes, patch)
2009-11-20 01:06 UTC, David Hoyt 		none Details | Review
Fixes tone_detect.c (336 bytes, patch)
2009-11-20 01:06 UTC, David Hoyt 		none Details | Review

Description David Hoyt 2009-11-20 01:06:06 UTC 
When compiling with MSVC, gst/dtmf/tone_detect.h is missing <stdint.h> and results in a compile error. It's also missing guards that prevent multiple inclusion.
Comment 1 David Hoyt 2009-11-20 01:06:37 UTC 
Created attachment 148151 [details] [review]
Fixes tone_detect.h
Comment 2 David Hoyt 2009-11-20 01:06:55 UTC 
Created attachment 148152 [details] [review]
Fixes tone_detect.c
Comment 3 Olivier Crête 2009-11-20 01:35:46 UTC 
Thank you, fixed in git:

commit 33108dec82105624086cf77149c4b4b39ba7bc49
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Thu Nov 19 20:33:07 2009 -0500

    dtmf: Update dtmfdetect to make it MSVC friendly
    
    https://bugzilla.gnome.org/show_bug.cgi?id=602465
Comment 4 Jan Schmidt 2009-11-20 10:17:42 UTC 
You should use the _stdint.h compatibility header generated by configure, as stdint.h is not available on all platforms:

  #include "_stdint.h"

is the correct form.
Comment 5 Olivier Crête 2009-11-20 15:33:23 UTC 
Thanks, didn't know about that trick:

commit 3865aadb653f84cec5a85e80daca48be75b9129b
Author: Olivier Crête <tester@tester.ca>
Date:   Fri Nov 20 10:31:47 2009 -0500

    dtmf: Use _stdint.h from configure
    
    https://bugzilla.gnome.org/show_bug.cgi?id=602465