GNOME Bugzilla – Bug 602437
[playbin2] [gapless] Completely broken when switching between files with audio/video only
Last modified: 2010-07-16 15:41:50 UTC
See summary, this probably caused using a single clock or something. Can easily be reproduced by using test7 from gst-plugins-base/gst/playback on a file with audio only followed by a file with video only or the other way around.
This also depends a bit on bug #537050, on top of that patch something is necessary to keep the running time between different types of streams.
Wim says that playsink needs to set the running time on the sinks so that they're all in sync, even if one sink doesn't get data for some groups. Can be done by keeping track of the segments in playsink and newsegment events. For streams to be synchronized the running time should be the same on all of them. The same needs to be done in playbin2 now for the QoS event adjusting.
Created attachment 149203 [details] [review] playbin2: Only keep track of the segments of a main stream To have all streams synchronized they need to have the same running times, which means that we can simply take the running time from one stream.
(In reply to comment #3) > Created an attachment (id=149203) [details] [review] > playbin2: Only keep track of the segments of a main stream > > To have all streams synchronized they need to have the same > running times, which means that we can simply take the running > time from one stream. This now makes sure that on the playbin2 side, for the QoS event adjusting, the running time is always correct.
Not sure if this is the best solution though: what happens if another stream than the selected main stream is a bit longer?
I have a patch and will push it after release.
commit 405b47a79ac92b73a4994aea73ceadc6ea043ec6 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sun Jul 11 14:44:10 2010 +0200 playsink: Fix gapless playback in many non-simple scenarios Before gapless playback failed when switching between audio-only, video-only and audio-video files, when choosing different clocks and when the different streams had different durations. This is now handled by a helper element, which keeps track of the running times of all streams and synchronizes them. Fixes bug #602437. commit f835533cb4c9b4af51bb1f8f1af50bf7955bda46 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sun Jul 11 14:43:52 2010 +0200 playbin2: Remove QOS event adjustments for gapless playback mode