GNOME Bugzilla – Bug 602420
Should use status icons from the theme
Last modified: 2011-08-29 10:12:37 UTC
At the moment Empathy is shipping its own status icon (available, away, dnd...) making them not themable. We should at some point stop doing that and use icons from the theme. The icon naming spec [1] defines the following icons: user-available The icon used when a user on a chat network is available to initiate a conversation with. user-away The icon used when a user on a chat network is away from their keyboard and the chat program. user-idle The icon used when a user on a chat network has not been an active participant in any chats on the network, for an extended period of time. user-offline The icon used when a user on a chat network is not available. [1] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
We should be sure that gnome-icon-theme is implementing all the icons we need. - available: bug #561861 (not in master yet) - away: bug #561858 - idle: bug #561859 - offline: bug #561860
Let's note that Ubuntu's theme is shipping a user-hidden icon. Could we worth to push it to the spec and as well.
*** Bug 547261 has been marked as a duplicate of this bug. ***
the one-canvas branch of gnome-icon-theme has: user-away - OK user-busy - OK user-idle - We don't use that user-invisible - OK user-offline - OK user-online - probably for available So that match pretty well our needs, it could have an icon for extended away but that's not very important. But it's not really what fd.o icon naming spec defines. From the spec: user-available - OK user-away - OK user-idle - The definition looks like extended-away. user-offline - OK It misses busy (user-idle maybe?) and invisible.
For the record, here is what empathy uses: empathy-offline empathy-offline - used for hidden, we really need a new icon empathy-available empathy-busy empathy-away empathy-extended-away empathy-pending - not really used, it is made for contacts you added in your roster, but didn't accept you yet. So their presence is unknown.
I'd say to use user-idle for your away status and user-away for your extended away, I'll think about pending, I guess there are already icons (ab)usable in the specs for that.
(In reply to comment #4) > > It misses busy (user-idle maybe?) and invisible. user-busy needs to be updated in the specs. It hasnt been done yet. But hopefully soon. A more clearer description of the statuses -idle and -away are listed > https://bugs.launchpad.net/icon-naming-spec/+bug/396822 (In reply to comment #5) > empathy-pending - not really used, it is made for contacts you added in your > roster, but didn't accept you yet. So their presence is unknown. Is this still being used? (In reply to comment #2) > Let's note that Ubuntu's theme is shipping a user-hidden icon. Could we worth > to push it to the spec and as well. Correction , in Ubuntu for Humanity , we included user-invisible . Since the icon is "invisible" shouldnt the status in the menus also be labeled "invisible" to keep it similar with the specs. Should i file a separate bug for that?
Since the status of an account is displayed also in the accounts-dialog treeview, I think this is more urgent. At the moment the offline-icon looks too much like a checkbox. Users could think that they can enable or disable their accounts by clicking on it.
(In reply to comment #8) > Since the status of an account is displayed also in the accounts-dialog > treeview, I think this is more urgent. At the moment the offline-icon looks too > much like a checkbox. Sooo true! I still think the whole status-in-treeview is totally "fail". The two rows of icons are very hard to set into context and the shape/color of the current offline icon really makes things worse.
I'm still waiting for a release of gnome-icon-theme... :(
Dobey: any plan to make a release soon? I really need one for Empathy...
Question is: can icons still be changed now (in UI freeze)? If not, would Empathy ask to break the freeze to get the new icons in (would be worth it because the current situation is kind of bad) So the possible solutions would be: a) Current gnome-icon-theme will be releases as 2.29/2.30 soon. I am not sure about UI freeze and it may be a problem because it is not widely tested yet. b) A gnome-icon-theme branch 2.30 could be created from the 2.28 branch with the IM status icons from master added to it. c) You could take the IM icons from gnome-icon-theme master and ship them with Empathy for 2.30, already changing the icon names so you just need to remove the bundled icons as soon as the new gnome-icon-theme is available. This would solve Empathy's icon bugs and get some wide scale testing of the new icons before 3.0, which would be desirable I think. d) Everything stays as it is now...
FWIW there is a gnome-icon-theme 2.29.0 release¹ now, containing the status icons and also carrying new emoticon icons. [1] http://ftp.gnome.org/pub/GNOME/sources/gnome-icon-theme/2.29/
Created attachment 155052 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/status-icon-602420 libempathy-gtk/empathy-images.h | 14 +++++---- libempathy-gtk/empathy-ui-utils.c | 54 ++++++++++++++++++++++++++++++++++-- 2 files changed, 59 insertions(+), 9 deletions(-)
This is a UI change so we should ask for an exception before merging it.
This affects MeeGo.
Created attachment 157056 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/status-icon-602420-2 data/icons/Makefile.am | 60 ++++---- .../hicolor_status_16x16_empathy-available.png | Bin 685 -> 0 bytes data/icons/hicolor_status_16x16_empathy-away.png | Bin 536 -> 0 bytes data/icons/hicolor_status_16x16_empathy-busy.png | Bin 618 -> 0 bytes .../hicolor_status_16x16_empathy-extended-away.png | Bin 752 -> 0 bytes .../icons/hicolor_status_16x16_empathy-offline.png | Bin 405 -> 0 bytes data/icons/hicolor_status_16x16_user-available.png | Bin 0 -> 685 bytes data/icons/hicolor_status_16x16_user-away.png | Bin 0 -> 536 bytes data/icons/hicolor_status_16x16_user-busy.png | Bin 0 -> 618 bytes data/icons/hicolor_status_16x16_user-idle.png | Bin 0 -> 752 bytes data/icons/hicolor_status_16x16_user-offline.png | Bin 0 -> 405 bytes .../hicolor_status_22x22_empathy-available.png | Bin 967 -> 0 bytes data/icons/hicolor_status_22x22_empathy-away.png | Bin 740 -> 0 bytes data/icons/hicolor_status_22x22_empathy-busy.png | Bin 1041 -> 0 bytes .../hicolor_status_22x22_empathy-extended-away.png | Bin 1115 -> 0 bytes .../icons/hicolor_status_22x22_empathy-offline.png | Bin 571 -> 0 bytes data/icons/hicolor_status_22x22_user-available.png | Bin 0 -> 967 bytes data/icons/hicolor_status_22x22_user-away.png | Bin 0 -> 740 bytes data/icons/hicolor_status_22x22_user-busy.png | Bin 0 -> 1041 bytes data/icons/hicolor_status_22x22_user-idle.png | Bin 0 -> 1115 bytes data/icons/hicolor_status_22x22_user-offline.png | Bin 0 -> 571 bytes .../hicolor_status_24x24_empathy-available.png | Bin 1075 -> 0 bytes data/icons/hicolor_status_24x24_empathy-away.png | Bin 825 -> 0 bytes data/icons/hicolor_status_24x24_empathy-busy.png | Bin 1081 -> 0 bytes .../hicolor_status_24x24_empathy-extended-away.png | Bin 1199 -> 0 bytes .../icons/hicolor_status_24x24_empathy-offline.png | Bin 570 -> 0 bytes data/icons/hicolor_status_24x24_user-available.png | Bin 0 -> 1075 bytes data/icons/hicolor_status_24x24_user-away.png | Bin 0 -> 825 bytes data/icons/hicolor_status_24x24_user-busy.png | Bin 0 -> 1081 bytes data/icons/hicolor_status_24x24_user-idle.png | Bin 0 -> 1199 bytes data/icons/hicolor_status_24x24_user-offline.png | Bin 0 -> 570 bytes .../hicolor_status_32x32_empathy-available.png | Bin 1433 -> 0 bytes data/icons/hicolor_status_32x32_empathy-away.png | Bin 1057 -> 0 bytes data/icons/hicolor_status_32x32_empathy-busy.png | Bin 1218 -> 0 bytes .../hicolor_status_32x32_empathy-extended-away.png | Bin 1612 -> 0 bytes .../icons/hicolor_status_32x32_empathy-offline.png | Bin 724 -> 0 bytes data/icons/hicolor_status_32x32_user-available.png | Bin 0 -> 1433 bytes data/icons/hicolor_status_32x32_user-away.png | Bin 0 -> 1057 bytes data/icons/hicolor_status_32x32_user-busy.png | Bin 0 -> 1218 bytes data/icons/hicolor_status_32x32_user-idle.png | Bin 0 -> 1612 bytes data/icons/hicolor_status_32x32_user-offline.png | Bin 0 -> 724 bytes .../hicolor_status_48x48_empathy-available.png | Bin 2211 -> 0 bytes data/icons/hicolor_status_48x48_empathy-away.png | Bin 1606 -> 0 bytes data/icons/hicolor_status_48x48_empathy-busy.png | Bin 1848 -> 0 bytes .../hicolor_status_48x48_empathy-extended-away.png | Bin 2622 -> 0 bytes .../icons/hicolor_status_48x48_empathy-offline.png | Bin 1062 -> 0 bytes data/icons/hicolor_status_48x48_user-available.png | Bin 0 -> 2211 bytes data/icons/hicolor_status_48x48_user-away.png | Bin 0 -> 1606 bytes data/icons/hicolor_status_48x48_user-busy.png | Bin 0 -> 1848 bytes data/icons/hicolor_status_48x48_user-idle.png | Bin 0 -> 2622 bytes data/icons/hicolor_status_48x48_user-offline.png | Bin 0 -> 1062 bytes .../hicolor_status_scalable_empathy-available.svg | 104 --------------- .../icons/hicolor_status_scalable_empathy-away.svg | 93 ------------- .../icons/hicolor_status_scalable_empathy-busy.svg | 140 -------------------- ...color_status_scalable_empathy-extended-away.svg | 120 ----------------- .../hicolor_status_scalable_empathy-offline.svg | 101 -------------- .../hicolor_status_scalable_user-available.svg | 104 +++++++++++++++ data/icons/hicolor_status_scalable_user-away.svg | 93 +++++++++++++ data/icons/hicolor_status_scalable_user-busy.svg | 140 ++++++++++++++++++++ data/icons/hicolor_status_scalable_user-idle.svg | 120 +++++++++++++++++ .../icons/hicolor_status_scalable_user-offline.svg | 101 ++++++++++++++ libempathy-gtk/empathy-images.h | 14 +- libempathy-gtk/empathy-ui-utils.c | 8 +- 63 files changed, 603 insertions(+), 595 deletions(-)
The above branch implement another approach. Rather than implement a fallback in the code, the Empathy status icons have been renamed to fit the name of the official ones. That way, Empathy uses those if they are not defined in the theme.
Looks good to me
We've got a gnome-icon-theme release with the user-* icons!
Merged to master. Will be in 2.31.1. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.