After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602390 - Editing photos memory leak
Editing photos memory leak
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
0.6.x
Other Linux
: Normal critical
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-19 10:15 UTC by Nick Sarten
Modified: 2009-11-20 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The memory usage as i repeatedly apply the "Straighten" operation from the edit menu (52.21 KB, image/png)
2009-11-19 10:15 UTC, Nick Sarten
Details

Description Nick Sarten 2009-11-19 10:15:58 UTC
Created attachment 148107 [details]
The memory usage as i repeatedly apply the "Straighten" operation from the edit menu

Hi there. This is my first Bugzilla bug report, so please excuse me if i do not initially do so correctly.

This bug has been reproduced under Ubuntu 9.04 with f-spot 0.5.0.3 and Ubuntu 9.10 with f-spot 0.6.1.4.

The bug basically consists of an apparent memory leak which causes the application's memory allocation to increase each time a photo is edited (and it does not decrease again at any later time, except whent he application is closed.

To reproduce the bug:
1. Import or open a large set of photos (i have 400+ in the albums i am editing).
2. Go through the photos, applying one edit operation from the edit menu to each photo.
3. After 30 or so photos, check memory usage. A significant increase should be observed.

While writing this report i have also identified another (more specific) way to reproduce the bug:
1. Import or open a set of photos.
2. Edit one photo.
3. Apply the "Straighten" operation from the edit menu multiple times (8-15) on the same image; a noticeable increase in memory usage is observed.

I have also filed a bug report at the Ubuntu Launchpad, https://bugs.launchpad.net/ubuntu/+source/f-spot/+bug/378954
Comment 1 Ruben Vermeersch 2009-11-19 10:40:03 UTC
Please don't set the alias field, if everyone goes nicknaming his pet peeves, this'll grow out of control. Having a good description is what matters.
Comment 2 Nick Sarten 2009-11-19 18:54:22 UTC
Oh ok, thanks. I was supposed to add keywords, not an alias.
Comment 3 Stephane Delcroix 2009-11-19 20:25:23 UTC
commit e5f5b1103d733257efdf746e8d50e6e4c8957876
Author: Stephane Delcroix <stephane@delcroix.org>
Date:   Thu Nov 19 21:22:17 2009 +0100

    Avoid leaking in Strighten Editor
    
    Dispose the IDisposables. fixes bgo #602390
Comment 4 Nick Sarten 2009-11-20 10:08:54 UTC
I have done some more investigation and found that the bug also occurs for the "Soft Focus" edit operation. I could not find any noticeable memory leaks for the other edit operations.
Comment 5 Stephane Delcroix 2009-11-20 10:33:48 UTC
soft focus fixed too
Comment 6 Nick Sarten 2009-11-20 20:16:41 UTC
Great, thanks.