After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602384 - Numeric tests fail on 32-bit platforms
Numeric tests fail on 32-bit platforms
Status: RESOLVED FIXED
Product: pygi
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: 0.6
Assigned To: Simon van der Linden
pygi-maint
Depends on: 603244 603355
Blocks:
 
 
Reported: 2009-11-19 08:26 UTC by Simon van der Linden
Modified: 2009-11-30 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the limit constants from glib and interpret G_MAXUINT32 as PyLong_FromLongLong (3.91 KB, patch)
2009-11-28 18:49 UTC, Tomeu Vizoso 		none Details | Review
Use the limit constants from glib and interpret G_MAXUINT32 as PyLong_FromLongLong (3.85 KB, patch)
2009-11-30 20:20 UTC, Tomeu Vizoso 		committed Details | Review

Description Simon van der Linden 2009-11-19 08:26:27 UTC 
Compiling PyGI on a 32-bit platform shows warnings and make numeric tests fail.
Comment 1 Tomeu Vizoso 2009-11-28 18:49:14 UTC 
Created attachment 148663 [details] [review]
Use the limit constants from glib and interpret G_MAXUINT32 as PyLong_FromLongLong
Comment 2 Simon van der Linden 2009-11-30 10:44:09 UTC 
Tomeu,

Why did you commit this?

The patch that has been committed in PyGObject is not correct, it fails on 64-bit machines.
Comment 3 Tomeu Vizoso 2009-11-30 10:49:07 UTC 
(In reply to comment #2)
> Tomeu,
> 
> Why did you commit this?
> 
> The patch that has been committed in PyGObject is not correct, it fails on
> 64-bit machines.

As just told you on IRC, I misread a bz email and though you had closed this one instead of https://bugzilla.gnome.org/show_bug.cgi?id=603244

Will revert.
Comment 4 Tomeu Vizoso 2009-11-30 20:20:03 UTC 
Created attachment 148784 [details] [review]
Use the limit constants from glib and interpret G_MAXUINT32 as PyLong_FromLongLong
Comment 5 Simon van der Linden 2009-11-30 20:22:43 UTC 
Review of attachment 148784 [details] [review]:

Awesome; works fine on my 64-bit machine. Please push!
Comment 6 Tomeu Vizoso 2009-11-30 20:26:26 UTC 
Attachment 148784 [details] pushed as 542fdf6 - Use the limit constants from glib and interpret G_MAXUINT32 as PyLong_FromLongLong