After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602328 - GetContactAttributes is called on every sent/received messages
GetContactAttributes is called on every sent/received messages
Status: RESOLVED NOTGNOME
Product: empathy
Classification: Core
Component: Chat
2.28.x
Other Linux
: High normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-18 17:56 UTC by Roman Yepishev
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Roman Yepishev 2009-11-18 17:56:29 UTC 
dbus-monitor --session shows that Empathy client calls GetContactAttributes every time a chat line is sent or received or ChatState is changed.

#telepathy:
rtagger: Zdra: dbus-monitor monitors the --session. Every time I send a message to your gabble.echo bot, the response triggers  GetContactAttributes call
jsoerd: Yup
jsoerd: not just for every message
jsoerd: for every letter you type as well
jsoerd: that's pretty bad
Comment 1 Guillaume Desmottes 2009-11-18 18:32:59 UTC 
Thanks for reporting this pretty nasty bug. I'm on it.
Comment 2 Guillaume Desmottes 2009-11-19 11:59:00 UTC 
By tracking this issue I discoverd various bugs:
- The ChatStateChanged signal was catched twice in Empathy. This is now fixed in master and gnome-2.28.
- empathy_tp_contact_factory_get_from_handle and _from_id were leaking the EmpatyContact object. I have a branch fixing that waiting for review.
- Tp-glib always call GetContactAttributes() even if the TpContact object already exists.

The latter is the reason of this bug. I forwared it to tp-glib and so can close this bug.
https://bugs.freedesktop.org/show_bug.cgi?id=25181