GNOME Bugzilla – Bug 602288
Shouldn't notify about scrollback messages
Last modified: 2011-08-29 10:12:28 UTC
Some muc services send you a scrollback on join, telepathy flags these with a Scrollback flag. Empathy unfortunately ignores this flag, while it should do several things with it: * Check if this message was already shown to the user in some way, and in that case don't log/display it * It probably shouldn't notify the user about such messages (they usually come in a flood) * Potentially mark the point at which you actually joined the room, so you know what people said while you were there
That flag was indeed added on my request specifically for this issue. I totally forgot to do the empathy part now that we have the needed flag. I think those messages could just be dropped, it conflicts with backlog we have stored, and compairing the timestamp of messages proved to not be trustable.
*** Bug 601263 has been marked as a duplicate of this bug. ***
(In reply to comment #0) > * Check if this message was already shown to the user in some way, and in > that case don't > log/display it Empathy master doesn't print latest messages from log any more, so now only scrollback messages received from the server are displayed. That should reduce the annoyance. I'm not sure about logging scrollback messages. For now I'd say to continue to log them (as they can contain valuable information). I don't want to spend too much time on the logger to try to detect old messages as we are going to switch to the telepathy logger at some point. > * It probably shouldn't notify the user about such messages (they usually > come in a flood) I agree. > * Potentially mark the point at which you actually joined the room, so you > know what people said > while you were there Sounds like a good idea. Does the Telepathy spec say us when we received all the scrollback messages? It would be good to display a "You joined the room" message after we received all of them.
Created attachment 148904 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/scrollback-602288 libempathy/empathy-message.c | 43 ++++++++++++++++++++++++++++++++++++++++++ libempathy/empathy-message.h | 4 +++ libempathy/empathy-tp-chat.c | 13 ++++++++--- 3 files changed, 56 insertions(+), 4 deletions(-)
Branch merged to master. Closing this bug as it was mainly about notifications. I opened bug #603596 and bug #603596 about the loggnig and displaying issues. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.