After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602224 - [0.11] Post tags only in sinks, synchronized to the stream
[0.11] Post tags only in sinks, synchronized to the stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other Linux
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-17 18:00 UTC by Sebastian Dröge (slomo)
Modified: 2011-12-06 17:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2009-11-17 18:00:32 UTC
In 0.11 elements should never ever post tag messages. Instead they should send tag events downstream, which then get converted to a message by the sink. This is the same as is done for EOS now already.

Advantage of this would be, that tags are only seen by the application at the time where the corresponding media is inside the sinks and not too early.

Changes would be that gst_element_found_tags() would send a tag event to all srcpads and that gst_element_found_tags_for_pad() only sends the events.

This can't be done for 0.10 because gst_element_found_tags() would only do something useful after the change if there are srcpads, while nowadays this doesn't matter (there only needs to be a bus).
Comment 1 Sebastian Dröge (slomo) 2009-11-17 18:02:01 UTC
Marking as blocker for 0.11. The changes in required in core are minimal but it's necessary to review the tag usage in all elements.
Comment 2 Wim Taymans 2011-11-28 13:15:23 UTC
In core.
Comment 3 Sebastian Dröge (slomo) 2011-11-28 16:03:28 UTC
Means, it is fixed in core now?
Comment 4 Wim Taymans 2011-12-06 17:22:42 UTC
yes, should be fixed.