After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602121 - osxaudiosrc: try native rate, disable multichannel
osxaudiosrc: try native rate, disable multichannel
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-16 17:46 UTC by Justin Karneges
Modified: 2011-09-22 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (8.36 KB, patch)
2009-11-16 17:47 UTC, Justin Karneges
needs-work Details | Review

Description Justin Karneges 2009-11-16 17:46:28 UTC
This is basically a dump of the changes I've made to osxaudiosrc since my last major submission in January, but reconciled with the changes made in Git since then.

The src should try to set the hardware rate if possible.

Multichannel is disabled, because it fails on my system.  Maybe there's a way to fix this, but if it works for nobody then it shouldn't have been enabled in the first place.

There are also some improvements to the coreaudio buffer creation code for interleaved vs non-interleaved (in case it ever helps us in future support for multichannel), as well as some extra debug lines and commented-out code for future reference.
Comment 1 Justin Karneges 2009-11-16 17:47:45 UTC
Created attachment 147918 [details] [review]
patch
Comment 2 Sebastian Dröge (slomo) 2011-05-23 14:12:07 UTC
Comment on attachment 147918 [details] [review]
patch

Please refresh the patch against latest GIT to make it apply cleanly again and split the patch into separate patches, each having one functional change. And include descriptions of what you change why in the commit messages :)
Comment 3 Akhil Laddha 2011-07-07 05:19:32 UTC
Justin, will you please provide updated patch as requested in comment#2, tia
Comment 4 Akhil Laddha 2011-09-22 09:15:08 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!