After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602118 - Wrong encoding for users of the lib in non UTF-8 system
Wrong encoding for users of the lib in non UTF-8 system
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-11-16 17:01 UTC by Pascal Terjan
Modified: 2009-11-17 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch adding the call to bind_textdomain_codeset (781 bytes, patch)
2009-11-16 17:03 UTC, Pascal Terjan
none Details | Review
Add call to bind_textdomain_codeset (838 bytes, patch)
2009-11-16 17:12 UTC, Pascal Terjan
committed Details | Review

Description Pascal Terjan 2009-11-16 17:01:35 UTC
Many strings fail on non UTF-8 system when displaying the window from gnome-phone-manager to select BT phone:

(gnome-phone-manager:21028): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Erreur à la ligne 1, caractère 66 : Texte codé en UTF-8 non valide dans le nom - « Afficher seulement les p\xe9riph\xe9riques Bluetooth avec... » est non valide

(gnome-phone-manager:21028): Gtk-WARNING **: Invalid input string

(gnome-phone-manager:21028): Gtk-WARNING **: Invalid input string

(gnome-phone-manager:21028): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

(gnome-phone-manager:21028): Gtk-WARNING **: Invalid input string

(gnome-phone-manager:21028): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

This is because gnome-bluetooth lib uses gnome-bluetooth2 as domain and nothing calls bind_textdomain_codeset on this domain.

I have a patch to fix bluetooth_chooser by adding the call in bluetooth_chooser_init but other parts of the libs probably need the same fix.
Comment 1 Pascal Terjan 2009-11-16 17:03:27 UTC
Created attachment 147910 [details] [review]
Patch adding the call to bind_textdomain_codeset
Comment 2 Pascal Terjan 2009-11-16 17:09:22 UTC
Hmm my patch is wrong, it would be more efficient to do it only in class init and not in _init
Comment 3 Pascal Terjan 2009-11-16 17:12:48 UTC
Created attachment 147912 [details] [review]
Add call to bind_textdomain_codeset