GNOME Bugzilla – Bug 602052
Text search options need small revisions for usability
Last modified: 2018-06-29 22:30:43 UTC
When searching for transactions with text field criteria, the user has the following choices: 'contains' 'matches regex' 'does not match regex' Joe Public does not know what a 'regex' is, this term is developer-centric. I would suggest adding another option to ensure he can exclude specific text content: 'contains' 'does not contain' 'matches regex' 'does not match regex' Those who know what a regex is can still do as they please but we need to accommodate the average user. - - - Also, I'm not sure why a regular button was used for the 'Case Insensitive?' option, it isn't always obvious that the button is depressed. Never include a question mark in a label, pressing it makes it seem as if the user is asking a question. This should be a checkbox instead shown as: [x] 'Case sensitive'
Also, for boolean fields such as 'Balanced' the user is provided with two widgets, a dropdown with 'is, is not' choices and a 'set true' button. You only really need one dropdown with 'is true, is false' choices.
Created attachment 184851 [details] [review] changes the search "Case Insensitve?" button to a checkbox. I agree with bcr@wt.net that "Case Insensitive?" should be a checkbox. I've attached a patch that changes that (it's pretty trivial).
Thanks for changing it to a checkbox but did you change the label as well? It should read as 'Case sensitive' and be unchecked by default. Question marks have no place in labels.
@bcr@wt.net you're totally correct, it should be "Case Sensitive" and be unchecked by default. I'm a complete GTK noob so it'll take me a bit more time to figure out how to do that, but I'll submit a new patch when I do.
Comment on attachment 184851 [details] [review] changes the search "Case Insensitve?" button to a checkbox. According to the discussion above, it should change its default and be slightly reworded.
Created attachment 187842 [details] [review] revised patch to change the search case insensitive to a checkbox This should work better - it now defaults to off, and is captioned "Match case" instead of "Case Insensitive?" which I think is clearer.
Comment on attachment 187842 [details] [review] revised patch to change the search case insensitive to a checkbox r20649, thanks a lot!
(not back-ported to 2.4 because it introduces the new string, but it will be in 2.5.0)
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=602052. Please update any external references or bookmarks.