After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601907 - Metacity crashes when flashing undecorated window's frame for Xkb bell event
Metacity crashes when flashing undecorated window's frame for Xkb bell event
Status: RESOLVED DUPLICATE of bug 598231
Product: metacity
Classification: Other
Component: general
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2009-11-14 16:38 UTC by Daniel Erat
Modified: 2009-11-16 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to flash screen instead if window has no frame (2.00 KB, patch)
2009-11-14 16:38 UTC, Daniel Erat 		none Details | Review
program that triggers the crash -- run it and click in the window (2.01 KB, text/x-csrc)
2009-11-14 16:45 UTC, Daniel Erat 		  Details
slightly better patch (1.98 KB, patch)
2009-11-14 17:09 UTC, Daniel Erat 		none Details | Review

Description Daniel Erat 2009-11-14 16:38:26 UTC 
Created attachment 147731 [details] [review]
patch to flash screen instead if window has no frame

Metacity hits a failed assertion in bell_flash_window_frame() when it tries to flash the window frame for an undecorated (via _MOTIF_WM_HINTS) window -- see https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/467972 .  The attached patch against 2.28.0 fixes this.
Comment 1 Daniel Erat 2009-11-14 16:45:03 UTC 
I'm also attaching a small program demonstrating the issue.  If you have "Visual alert" set to "Flash window" in Sound Preferences -> Sounds and you run this program and click in the undecorated window, Metacity crashes.

This is affecting Chromium users: http://code.google.com/p/chromium/issues/detail?id=27654 .  I haven't been able to reproduce this using Chromium yet, though; the XkbBellNotify event that I'm seeing GTK apps send has its 'window' field unset, so Metacity uses the focused window instead, for which it already checks that the frame is present.
Comment 2 Daniel Erat 2009-11-14 16:45:42 UTC 
Created attachment 147733 [details]
program that triggers the crash -- run it and click in the window
Comment 3 Daniel Erat 2009-11-14 17:09:49 UTC 
Created attachment 147735 [details] [review]
slightly better patch
Comment 4 Owen Taylor 2009-11-16 14:27:22 UTC 
Dup of bug 598231 which also has a patch, haven't compared the two patches.

*** This bug has been marked as a duplicate of bug 598231 ***
Comment 5 Daniel Erat 2009-11-16 16:03:12 UTC 
The patches are functionally identical.