After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601890 - Make bluetooth support optional
Make bluetooth support optional
Status: RESOLVED FIXED
Product: gnome-user-share
Classification: Core
Component: bluetooth
2.28.x
Other FreeBSD
: Normal enhancement
: ---
Assigned To: gnome-user-share maintainers
gnome-user-share maintainers
: 697537 703056 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-14 12:42 UTC by Josselin Mouette
Modified: 2013-07-24 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check if bluetooth is available at compile time (17.11 KB, patch)
2009-11-14 12:42 UTC, Josselin Mouette 		none Details | Review
Updated patch for git (17.25 KB, patch)
2012-04-29 09:28 UTC, Sjoerd Simons 		needs-work Details | Review
Make bluetooth support optional (9.29 KB, patch)
2013-03-31 16:24 UTC, Emilio Pozuelo Monfort 		none Details | Review

Description Josselin Mouette 2009-11-14 12:42:50 UTC 
Created attachment 147718 [details] [review]
Check if bluetooth is available at compile time

Since gnome-bluetooth doesn’t build on non-Linux architectures, it affects gnome-user-share as well. The attached patch makes bluetooth support optional.
Comment 1 Sjoerd Simons 2012-04-29 09:28:49 UTC 
Created attachment 213042 [details] [review]
Updated patch  for git
Comment 2 Bastien Nocera 2013-02-21 10:45:27 UTC 
Comment on attachment 213042 [details] [review]
Updated patch  for git

The patch is outdated, and doesn't apply anymore.

The configure checks needs to require --disable-bluetooth to be passed to disable Bluetooth support (no automagic based on whether Bluetooth is available or not).

Furthermore, this will need a gnome-control-center patch to hide Bluetooth support in the Sharing panel if gnome-bluetooth is not available.
Comment 3 Emilio Pozuelo Monfort 2013-03-31 16:24:06 UTC 
Created attachment 240221 [details] [review]
Make bluetooth support optional

Updated patch against git master. This new version adds a --disable-bluetooth configure swith. The build will fail if you don't have libgnome-bluetooth installed and don't explicitly configure with --disable-bluetooth.
Comment 4 Emilio Pozuelo Monfort 2013-05-07 10:07:52 UTC 
*** Bug 697537 has been marked as a duplicate of this bug. ***
Comment 5 Emilio Pozuelo Monfort 2013-05-07 10:08:28 UTC 
This will be obsolete once bug 699816 is closed.
Comment 6 Bastien Nocera 2013-07-24 07:13:28 UTC 
*** Bug 703056 has been marked as a duplicate of this bug. ***
Comment 7 Bastien Nocera 2013-07-24 08:07:55 UTC 
Bluetooth support is disabled by default for now. It will be up to you, the distributions, to make sure that both gnome-control-center and gnome-user-share are shipped with the same configuration.

commit 0667a68288fa105e1136b0882a8064f2db693c88
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Jul 24 09:46:35 2013 +0200

    build: Make Bluetooth support optional
    
    This is useful for platforms where gnome-bluetooth isn't available
    (eg. non-Linux) and for Linux right now, as obexd isn't quite
    suitable for use in a Desktop setting:
    - there's no control over ObexFTP enablement, or clients
    - Neither ObexPush nor ObexFTP can be turned off when the
      user loses the console, leading to multiple ObexFTP/ObexPush
      instances on a single machine, which will confuse clients