After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601854 - [overview] Integer align workspace and pane positioning
[overview] Integer align workspace and pane positioning
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 601948 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-13 23:52 UTC by Colin Walters
Modified: 2009-11-16 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[overview] Integer align workspace and pane positioning (2.70 KB, patch)
2009-11-13 23:52 UTC, Colin Walters
reviewed Details | Review
[overview] Integer align workspace and pane positioning (2.65 KB, patch)
2009-11-16 15:41 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2009-11-13 23:52:33 UTC
We had previously been leaving the scaled workspace at a non-integral
position which didn't look obviously ugly, but now that we're
constraining the popup pane to the workspace size, we really need
to ensure that we're using integral positions here.
Comment 1 Colin Walters 2009-11-13 23:52:35 UTC
Created attachment 147701 [details] [review]
[overview] Integer align workspace and pane positioning
Comment 2 Andreas Proschofsky 2009-11-14 00:13:51 UTC
Fix works fine for me, solves the "compressed" display in the applications and recent document list
Comment 3 Dan Winship 2009-11-14 15:27:57 UTC
Comment on attachment 147701 [details] [review]
[overview] Integer align workspace and pane positioning

>+            this._activeDisplayPane.actor.width = Math.floor(displayGridColumnWidth * 2);

but, seen in the context part of the diff:

>         this._dash.actor.set_size(displayGridColumnWidth, contentHeight);

which will presumably cause problems elsewhere? Should we just make sure displayGridColumnWidth is an integer instead?
Comment 4 Baptiste Mille-Mathias 2009-11-15 10:48:11 UTC
*** Bug 601948 has been marked as a duplicate of this bug. ***
Comment 5 Colin Walters 2009-11-16 15:41:32 UTC
Created attachment 147903 [details] [review]
[overview] Integer align workspace and pane positioning

We had previously been leaving the scaled workspace at a non-integral
position which didn't look obviously ugly, but now that we're
constraining the popup pane to the workspace size, we really need
to ensure that we're using integral positions here.
Comment 6 Colin Walters 2009-11-16 15:56:42 UTC
(In reply to comment #3)
> (From update of attachment 147701 [details] [review])
> >+            this._activeDisplayPane.actor.width = Math.floor(displayGridColumnWidth * 2);
> 
> but, seen in the context part of the diff:
> 
> >         this._dash.actor.set_size(displayGridColumnWidth, contentHeight);
> 
> which will presumably cause problems elsewhere? Should we just make sure
> displayGridColumnWidth is an integer instead?

Yeah, probably saner.  New patch attached.