After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601756 - a11y crashing Podcasts
a11y crashing Podcasts
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-13 01:30 UTC by Gabriel Burt
Modified: 2009-11-13 22:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make status names extendable by ColumnCellStatusIndicator subclasses (4.37 KB, patch)
2009-11-13 20:22 UTC, Eitan Isaacson 		none Details | Review
Avoid accessing out-of-range indexes in ColumnCellStatusIndicator.icon_names (1.10 KB, patch)
2009-11-13 20:24 UTC, Eitan Isaacson 		committed Details | Review
Make status names extendable by ColumnCellStatusIndicator subclasses (4.37 KB, patch)
2009-11-13 20:54 UTC, Eitan Isaacson 		committed Details | Review

Description Gabriel Burt 2009-11-13 01:30:14 UTC 
Got this crash while messing around with podcasts.

System.IndexOutOfRangeException: Array index is out of range.
  at Banshee.Collection.Gui.ColumnCellStatusIndicator.GetTextAlternative (System.Object obj) [0x00028] in /home/gabe/Projects/banshee/src/Core/Banshee.ThickClient/Banshee.Collection.Gui/ColumnCellStatusIndicator.cs:163 
  at Banshee.Collection.Gui.ColumnCellStatusIndicatorAccessible..ctor (System.Object bound_object, Banshee.Collection.Gui.ColumnCellStatusIndicator cell, ICellAccessibleParent parent) [0x00009] in /home/gabe/Projects/banshee/src/Core/Banshee.ThickClient/Banshee.Collection.Gui/ColumnCellStatusIndicator.cs:51 
  at Banshee.Collection.Gui.ColumnCellStatusIndicator.GetAccessible (ICellAccessibleParent parent) [0x00000] in /home/gabe/Projects/banshee/src/Core/Banshee.ThickClient/Banshee.Collection.Gui/ColumnCellStatusIndicator.cs:149
Comment 1 Gabriel Burt 2009-11-13 01:32:37 UTC 
Ah, I think it's when I right click on the podcast track list
Comment 2 Eitan Isaacson 2009-11-13 20:22:53 UTC 
Created attachment 147688 [details] [review]
Make status names extendable by ColumnCellStatusIndicator subclasses
Comment 3 Eitan Isaacson 2009-11-13 20:24:11 UTC 
Created attachment 147689 [details] [review]
Avoid accessing out-of-range indexes in ColumnCellStatusIndicator.icon_names
Comment 4 Eitan Isaacson 2009-11-13 20:51:22 UTC 
Comment on attachment 147688 [details] [review]
Make status names extendable by ColumnCellStatusIndicator subclasses

This depends on the later patch, so i will resubmit it.
Comment 5 Eitan Isaacson 2009-11-13 20:54:48 UTC 
Created attachment 147691 [details] [review]
Make status names extendable by ColumnCellStatusIndicator subclasses

These two patches should fix the crash and allow subclasses of ColumnCellStatusIndicator to provide alternative text for status icons.
Comment 6 Gabriel Burt 2009-11-13 20:55:21 UTC 
These look fine, feel free to commit/push to master.  Use 50-char limit for first line of commit msg.